-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Convert SuggestedChartRevision db access to knex #3074
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
60eb9ff
to
94ff680
Compare
94ff680
to
3ae74f4
Compare
3ae74f4
to
b2431d2
Compare
6eaf0fb
to
8786e68
Compare
b3006ec
to
7377fb3
Compare
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
77143f5
to
baa468d
Compare
51be3d9
to
92618af
Compare
2192ceb
to
1412099
Compare
1412099
to
1d6af5f
Compare
506045b
to
fdb0dbc
Compare
1d6af5f
to
5ec1f28
Compare
Also make sure we pass down knex in the related places and use transaction scopes where appropriate.
fdb0dbc
to
8a389c2
Compare
5ec1f28
to
f53a34e
Compare
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
d1f180f
to
66b77fa
Compare
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
This PR attempts to change use of the
suggested_chart_revisions
table to knex. It is WIP at this point as the code changes led to some more restructuring