-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate donate Netlify function to Cloudflare (#proj-donor-page v2 option 1) #2998
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
c350559
to
1bbd0cb
Compare
edd1096
to
d951ef4
Compare
c2a847e
to
f78ea7d
Compare
d951ef4
to
4629849
Compare
e5c086c
to
d1eaadf
Compare
4629849
to
8c325fd
Compare
5c4a71b
to
4957d0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this and it works. Some questions:
- I never saw a captcha (I tried with an incognito browser to check if this is because of cookies by google or similar but no captcha there either). Is that ok?
- I didn't get any email - is that expected?
Small nit: when you enter amount "0" you see the wrong error message (you should see the one that tells you the valid amount but instead it says you should enter an amount - i.e. it treats 0 as empty)
Another nit: there is a missing closing quote after the name in the summary message that is shown in stripe
8c325fd
to
5b3df75
Compare
4957d0e
to
77b8356
Compare
5b3df75
to
4fac8a1
Compare
Prevent conflict with /donate/thank-you redirect
f7892b9
to
98022de
Compare
This is part of the migration of the donor flow from Netlify to Cloudflare, tracked in #2947.
This PR deals specifically with the migration of the
donate
function, which handles the creation of a Stripe checkout session upon clicking on "Donate" on /donate. See README.md for a complete sequence diagram.Additionally, it tackles:
This PR also brings some reader-facing improvements:
Non-code actions:
/donation/donate
)Still unclear:
(where to set env vars? Configure preview environment on Cloudflare dashboard?)Reference: