Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local env for cloudflare functions with makefile #2978

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Local env for cloudflare functions with makefile #2978

merged 2 commits into from
Jan 11, 2024

Conversation

mlbrgl
Copy link
Member

@mlbrgl mlbrgl commented Dec 1, 2023 •
edited
Loading

This PR adds local development support for Cloudflare Pages functions.

It integrates the wrangler dev server to the make up.full command.

@mlbrgl mlbrgl mentioned this pull request Dec 1, 2023
Merged
@mlbrgl
Copy link
Member Author

mlbrgl commented Dec 1, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from e0c67d0 to a88a404 Compare December 1, 2023 17:17
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 04b9aa2 to 16c9b49 Compare December 1, 2023 17:17
@mlbrgl mlbrgl marked this pull request as ready for review December 4, 2023 17:53
@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from a88a404 to 7c0dba1 Compare December 6, 2023 12:56
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 015d26f to edd1096 Compare December 6, 2023 12:56
@mlbrgl mlbrgl mentioned this pull request Dec 6, 2023
Merged
9 tasks
@mlbrgl mlbrgl requested a review from danyx23 December 8, 2023 18:00
@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from 7c0dba1 to c266e03 Compare December 12, 2023 08:14
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from edd1096 to d951ef4 Compare December 12, 2023 08:14
@danyx23
Copy link
Contributor

danyx23 commented Dec 12, 2023

Could you document this a bit more please? It's unclear to me what this does - which kinds of things does the cf functions dev server expose?

Please also integrate it into the make up command.

There is a --compatibility-date flag in the startLocalCloudflareFunctions script call - when is that supposed to be updated? Maybe add a comment there?

@danyx23
Copy link
Contributor

danyx23 commented Dec 12, 2023

I just saw that this is documented in the readme in the next PR - so mostly including this in make up remains here :)

@mlbrgl
Copy link
Member Author

mlbrgl commented Dec 13, 2023 •
edited
Loading

@danyx23 Thanks! Sorry for spreading the docs across multiple PRs!

Yes, I haven't fully dived into the other CF functions code yet, and I didn't want to blindly add this startup command. Feel free to commit to this PR though if you think it's good to go!

@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from c266e03 to 15011f6 Compare December 14, 2023 08:20
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from d951ef4 to 4629849 Compare December 14, 2023 08:20
@mlbrgl mlbrgl mentioned this pull request Dec 14, 2023
Merged
1 task
@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from 15011f6 to 3ff675e Compare December 19, 2023 09:46
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 4629849 to 8c325fd Compare December 19, 2023 09:46
danyx23
danyx23 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from 3ff675e to dc1c9e2 Compare December 27, 2023 07:23
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 8c325fd to 5b3df75 Compare December 27, 2023 07:23
@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from dc1c9e2 to 49d9722 Compare December 29, 2023 19:34
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 5b3df75 to 4fac8a1 Compare December 29, 2023 19:35
@mlbrgl mlbrgl mentioned this pull request Dec 29, 2023
Merged
@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from 49d9722 to ee7c26b Compare January 3, 2024 08:27
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 4fac8a1 to 51ddc61 Compare January 3, 2024 08:27
@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from ee7c26b to ba46867 Compare January 4, 2024 13:41
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 51ddc61 to 6a17c32 Compare January 4, 2024 13:41
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 6a17c32 to fcabd46 Compare January 4, 2024 14:09
@mlbrgl mlbrgl mentioned this pull request Jan 5, 2024
Merged
@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from ba46867 to 099cf0b Compare January 10, 2024 13:52
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from fcabd46 to 865b4c6 Compare January 10, 2024 13:52
@mlbrgl mlbrgl mentioned this pull request Jan 10, 2024
Merged
@mlbrgl mlbrgl force-pushed the donate-bugsnag-notify branch from 099cf0b to de666fd Compare January 10, 2024 15:22
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from 865b4c6 to cf10ef2 Compare January 10, 2024 15:22
@mlbrgl mlbrgl mentioned this pull request Jan 10, 2024
Merged
@mlbrgl
Copy link
Member Author

mlbrgl commented Jan 11, 2024 •
edited
Loading

Merge activity

  • Jan 11, 12:29 PM: @mlbrgl started a stack merge that includes this pull request via Graphite.
  • Jan 11, 12:30 PM: Graphite rebased this pull request as part of a merge.
  • Jan 11, 12:30 PM: @mlbrgl merged this pull request with Graphite.

Base automatically changed from donate-bugsnag-notify to master January 11, 2024 17:29
@mlbrgl mlbrgl force-pushed the local-env-cloudflare-functions branch from cf10ef2 to 2c25b47 Compare January 11, 2024 17:29
@mlbrgl mlbrgl merged commit 6669f7b into master Jan 11, 2024
13 of 14 checks passed
@mlbrgl mlbrgl deleted the local-env-cloudflare-functions branch January 11, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyx23 danyx23 danyx23 approved these changes

Assignees

@mlbrgl mlbrgl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlbrgl @danyx23