Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render source fields as markdown instead of HTML #2639

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Sep 19, 2023

This PR switches the rendering of text from Source in the sources tab of Grapher from HTML to markdown. This is the companion PR for this PR in the ETL that converts legacy HTML to markdown in sources.

This PR implements #2520

@danyx23 danyx23 linked an issue Sep 19, 2023 that may be closed by this pull request
@danyx23 danyx23 requested a review from ikesau September 19, 2023 17:50
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danyx23 danyx23 merged commit 429018b into master Sep 20, 2023
16 checks passed
@danyx23 danyx23 deleted the render-sources-as-markdown-2520 branch September 20, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch grapher sources rendering to markdown
2 participants