Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch grapher sources rendering to markdown #2520

Closed
danyx23 opened this issue Aug 8, 2023 · 0 comments · Fixed by #2639
Closed

Switch grapher sources rendering to markdown #2520

danyx23 opened this issue Aug 8, 2023 · 0 comments · Fixed by #2639
Labels
feature needs triage viz

Comments

@danyx23
Copy link
Contributor

danyx23 commented Aug 8, 2023

We used to use HTML sometimes in Sources so that the Sources tab would render links or bullet points. With the new metadata we now want to standardize on our markdown flavor. This will require the Grapher sources tab to switch from using dangerouslySetInnerHTML to MarkdownTextWrap.

This will have to be merged in sync with the ETL work to replace HTML with markdown: owid/etl#1422

It will probably also be good to to implement #2489 before doing this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature needs triage viz
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Render source fields as markdown instead of HTML owid/owid-grapher
2 participants
@danyx23 @sophiamersmann