Expo SDK 50 & Android deep link fix #18

simonsturge · 2024-02-24T14:43:07Z

Updating android build.gradle to match one of a newly created module, which allows for building with Expo SDK 50.

I'm unsure if any other changes are required, however, I have tested in my own project using SDK 50, and I can confirm it works for me.

adamhari · 2024-03-01T20:48:23Z

Can also confirm this PR fixes my android build issue on SDK 50.

simonsturge · 2024-03-16T00:17:03Z

I have modified the android plugin to take the intent filters from the main activity, instead of just creating the main intent filter. This copies any custom url schemas and share intents into the new activity aliases.

If any other plugins modify the main activity intent filters, we need to ensure that this plugin is listed FIRST in the plugins array.

apokusin · 2024-03-18T11:25:52Z

Closes #15 as well

…user may want to use adaptive icons built into expo)

Elue-dev · 2024-03-31T22:26:57Z

anyone know why this package dosent work on android anymore? Expo SDK 50, it works fine on iOS

theblondealex · 2024-04-09T16:02:23Z

@outsung Please merge this

theblondealex · 2024-04-09T16:13:18Z

can anyone help with how to add this into a project for EAS Build, whenn running eas build it grabs the package from NPM and as such the main package not this fork, how do I point it to this forked patch so I can build for android?

simonsturge · 2024-04-09T16:25:44Z

can anyone help with how to add this into a project for EAS Build, whenn running eas build it grabs the package from NPM and as such the main package not this fork, how do I point it to this forked patch so I can build for android?

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon",

Please do your own testing as I have modified a few things in this PR.

I have added a new 'platforms' prop that can be provided in the config setup. I personally did not want Android support as I wanted to use adaptive icons instead. usage as follows:

[
        "expo-dynamic-app-icon",
        {
          "light": {
            "image": "./src/assets/icons/icon_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          },
          "dark": {
            "image": "./src/assets/icons/icon_dark_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          }
        }
      ],

Elue-dev · 2024-04-09T16:28:07Z

can anyone help with how to add this into a project for EAS Build, whenn running eas build it grabs the package from NPM and as such the main package not this fork, how do I point it to this forked patch so I can build for android?

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon",

Please do your own testing as I have modified a few things in this PR.

I have added a new 'platforms' prop that can be provided in the config setup. I personally did not want Android support as I wanted to use adaptive icons instead. usage as follows:
[
        "expo-dynamic-app-icon",
        {
          "light": {
            "image": "./src/assets/icons/icon_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          },
          "dark": {
            "image": "./src/assets/icons/icon_dark_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          }
        }
      ],

please does this library now work properly for android? android build still fails for my app, using Expo SDK 50

theblondealex · 2024-04-09T16:31:12Z

can anyone help with how to add this into a project for EAS Build, whenn running eas build it grabs the package from NPM and as such the main package not this fork, how do I point it to this forked patch so I can build for android?

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon",

Please do your own testing as I have modified a few things in this PR.

I have added a new 'platforms' prop that can be provided in the config setup. I personally did not want Android support as I wanted to use adaptive icons instead. usage as follows:
[
        "expo-dynamic-app-icon",
        {
          "light": {
            "image": "./src/assets/icons/icon_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          },
          "dark": {
            "image": "./src/assets/icons/icon_dark_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          }
        }
      ],

Thank you, wasnt sure how to link it, will try this and test it myself and update, appreciate the switft reply and help

simonsturge · 2024-04-09T16:33:32Z

please does this library now work properly for android? android build still fails for my app, using Expo SDK 50

are you building using my fork? I'm using expo 50.0.14 and android builds ok for me. if you're referring to the 'platform' prop I have added, this is optional if you only intend to use it for one platform, like myself.

Thank you, wasnt sure how to link it, will try this and test it myself and update, appreciate the switft reply and help

np. hope it works

Elue-dev · 2024-04-09T16:35:30Z

please does this library now work properly for android? android build still fails for my app, using Expo SDK 50

are you building using my fork? I'm using expo 50.0.14 and android builds ok for me. if you're referring to the 'platform' prop I have added, this is optional if you only intend to use it for one platform, like myself.

Thank you, wasnt sure how to link it, will try this and test it myself and update, appreciate the switft reply and help

np. hope it works

thanks for the response, sorry i’m not sure what you mean by “building using my fork”, can you help shed more light? thanks

simonsturge · 2024-04-09T16:38:33Z

thanks for the response, sorry i’m not sure what you mean by “building using my fork”, can you help shed more light? thanks

until this PR is merged, in your package.json, use my fork as the source instead

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon"

theblondealex · 2024-04-12T21:43:20Z

This worked for a dev build, (whicH failed before) so im sure itll work for a prod build thanks so much

Elue-dev · 2024-04-12T21:45:57Z

when will this be merged?!

theblondealex · 2024-04-12T21:50:16Z

it may not be and @outsung has no obligation to, the kindness of @simonsturge means its still usable, as they mentioned you can just use it in our project with this

until this PR is merged, in your package.json, use my fork as the source instead

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon"

SunlightLuck · 2024-04-22T22:04:57Z

can anyone help with how to add this into a project for EAS Build, whenn running eas build it grabs the package from NPM and as such the main package not this fork, how do I point it to this forked patch so I can build for android?

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon",

Please do your own testing as I have modified a few things in this PR.

I have added a new 'platforms' prop that can be provided in the config setup. I personally did not want Android support as I wanted to use adaptive icons instead. usage as follows:
[
        "expo-dynamic-app-icon",
        {
          "light": {
            "image": "./src/assets/icons/icon_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          },
          "dark": {
            "image": "./src/assets/icons/icon_dark_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          }
        }
      ],

I tried "expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon"
but getting
CommandError: Failed to resolve plugin for module "expo-dynamic-app-icon" relative to "D:\Sanshu\fintech-clone-react-native"
while running
npx expo run:android

apokusin · 2024-04-22T22:26:10Z

can anyone help with how to add this into a project for EAS Build, whenn running eas build it grabs the package from NPM and as such the main package not this fork, how do I point it to this forked patch so I can build for android?

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon",
Please do your own testing as I have modified a few things in this PR.
I have added a new 'platforms' prop that can be provided in the config setup. I personally did not want Android support as I wanted to use adaptive icons instead. usage as follows:
[
        "expo-dynamic-app-icon",
        {
          "light": {
            "image": "./src/assets/icons/icon_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          },
          "dark": {
            "image": "./src/assets/icons/icon_dark_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          }
        }
      ],
I tried "expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon" but getting CommandError: Failed to resolve plugin for module "expo-dynamic-app-icon" relative to "D:\Sanshu\fintech-clone-react-native" while running npx expo run:android

"expo-dynamic-app-icon": "git+https://github.com/simonsturge/expo-dynamic-app-icon#acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0",

This will pin it to a specific commit, which is preferred given this isn't an npm package with proper semver.

Reference material

SunlightLuck · 2024-04-22T23:29:13Z

can anyone help with how to add this into a project for EAS Build, whenn running eas build it grabs the package from NPM and as such the main package not this fork, how do I point it to this forked patch so I can build for android?

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon",
Please do your own testing as I have modified a few things in this PR.
I have added a new 'platforms' prop that can be provided in the config setup. I personally did not want Android support as I wanted to use adaptive icons instead. usage as follows:
[
        "expo-dynamic-app-icon",
        {
          "light": {
            "image": "./src/assets/icons/icon_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          },
          "dark": {
            "image": "./src/assets/icons/icon_dark_1024x1024.png",
            "prerendered": true,
            "platforms": ["ios"]
          }
        }
      ],
I tried "expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon" but getting CommandError: Failed to resolve plugin for module "expo-dynamic-app-icon" relative to "D:\Sanshu\fintech-clone-react-native" while running npx expo run:android
"expo-dynamic-app-icon": "git+https://github.com/simonsturge/expo-dynamic-app-icon#acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0",
This will pin it to a specific commit, which is preferred given this isn't an npm package with proper semver.

Reference material

thanks for your comment, I updated my package.json with "expo-dynamic-app-icon": "git+https://github.com/simonsturge/expo-dynamic-app-icon#acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0"
but getting this error while installing node_modules
C:\Users\Admin\AppData\Local\Yarn\Cache\v6\.tmp\cae3bc88f569b1a500984b83f06a3fd1.acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0.prepare\node_modules\expo-module-scripts\bin\expo-module-prepare:3
SyntaxError: Unexpected identifier

apokusin · 2024-04-23T00:09:50Z

thanks for your comment, I updated my package.json with "expo-dynamic-app-icon": "git+https://github.com/simonsturge/expo-dynamic-app-icon#acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0"

but getting this error while installing node_modules

C:\Users\Admin\AppData\Local\Yarn\Cache\v6\.tmp\cae3bc88f569b1a500984b83f06a3fd1.acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0.prepare\node_modules\expo-module-scripts\bin\expo-module-prepare:3

SyntaxError: Unexpected identifier

Hard to say without the full log.

First try 'yarn cache clean' and try install again.

Otherwise try deleting 'node_modules' and then 'yarn install' and 'npx pod-install'.

If it keeps happening I'd search for the error on Google as it seems environment-specific.

SunlightLuck · 2024-04-23T04:09:03Z

can anyone help with how to add this into a project for EAS Build, whenn running eas build it grabs the package from NPM and as such the main package not this fork, how do I point it to this forked patch so I can build for android?

"expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon",

Please do your own testing as I have modified a few things in this PR.

I have added a new 'platforms' prop that can be provided in the config setup. I personally did not want Android support as I wanted to use adaptive icons instead. usage as follows:

[
    "expo-dynamic-app-icon",
    {
      "light": {
        "image": "./src/assets/icons/icon_1024x1024.png",
        "prerendered": true,
        "platforms": ["ios"]
      },
      "dark": {
        "image": "./src/assets/icons/icon_dark_1024x1024.png",
        "prerendered": true,
        "platforms": ["ios"]
      }
    }
  ],
I tried "expo-dynamic-app-icon": "github:simonsturge/expo-dynamic-app-icon" but getting CommandError: Failed to resolve plugin for module "expo-dynamic-app-icon" relative to "D:\Sanshu\fintech-clone-react-native" while running npx expo run:android

"expo-dynamic-app-icon": "git+https://github.com/simonsturge/expo-dynamic-app-icon#acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0",

This will pin it to a specific commit, which is preferred given this isn't an npm package with proper semver.

Reference material

thanks for your comment, I updated my package.json with "expo-dynamic-app-icon": "git+https://github.com/simonsturge/expo-dynamic-app-icon#acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0"
but getting this error while installing node_modules
C:\Users\Admin\AppData\Local\Yarn\Cache\v6\.tmp\cae3bc88f569b1a500984b83f06a3fd1.acfd73827573e99a5e1bfbe47cf2fb1656e9ccf0.prepare\node_modules\expo-module-scripts\bin\expo-module-prepare:3
SyntaxError: Unexpected identifier
Hard to say without the full log.

First try 'yarn cache clean' and try install again.

Otherwise try deleting 'node_modules' and then 'yarn install' and 'npx pod-install'.

If it keeps happening I'd search for the error on Google as it seems environment-specific.

Tried to remove cache, node_modules and installed again, still get the same error.

apokusin · 2024-04-23T04:38:12Z

Tried to remove cache, node_modules and installed again, still get the same error.

Unfortunately I don't have the bandwidth to troubleshoot this issue.

However this issue seems related #21

beau6183 · 2024-06-13T19:26:51Z

@outsung It'd be great to get this merged. Completely blocked from using this lib on android due to the Java 11 dependency this introduces.

apokusin · 2024-06-13T19:42:09Z

@outsung It'd be great to get this merged. Completely blocked from using this lib on android due to the Java 11 dependency this introduces.

You can use the fork with these fixes mentioned here

kouloughli-hemza · 2024-06-18T18:25:59Z

@simonsturge im using this pr to be able to build android, i noticed that when ever i change the icon it ceate new lunch icon on device home screen, for IOS is correct, it happens for you this behaviour?

Elue-dev · 2024-06-21T08:52:13Z

@simonsturge im using this pr to be able to build android, i noticed that when ever i change the icon it ceate new lunch icon on device home screen, for IOS is correct, it happens for you this behaviour?

this happened to me too, i ended up not using the library, probably when its more stable for android

crumb1e · 2024-07-08T15:20:49Z

@simonsturge im using this pr to be able to build android, i noticed that when ever i change the icon it ceate new lunch icon on device home screen, for IOS is correct, it happens for you this behaviour?

this happened to me too, i ended up not using the library, probably when its not stable for android

did you manage to get dynamic icons working on android via another solution?

kouloughli-hemza · 2024-07-08T17:42:02Z

@simonsturge im using this pr to be able to build android, i noticed that when ever i change the icon it ceate new lunch icon on device home screen, for IOS is correct, it happens for you this behaviour?

this happened to me too, i ended up not using the library, probably when its not stable for android

did you manage to get dynamic icons working on android via another solution?

Not really, still have issue of duplicate icon

Wilson-Lim · 2024-09-02T07:15:01Z

expo-dynamic-app-icon-npm-1.2.0-66d634aad7.patch

This yarn berry patch works for me

kouloughli-hemza · 2024-09-12T14:46:23Z

seems like this is not working anymore
@simonsturge
do you have same issue?
was working fine , now it's gives same gradle error

i updated few things on package to make build possible on Android, and published to npm

https://www.npmjs.com/package/nixa-expo-dynamic-app-icon

thedev132 · 2024-09-15T21:17:22Z

@kouloughli-hemza Thanks for your fork! On android the size doesn't fill up the entire screen (addressing this issue: #3)

kouloughli-hemza · 2024-09-16T16:15:15Z

@kouloughli-hemza Thanks for your fork! On android the size doesn't fill up the entire screen (addressing this issue: #3)

there few issues on Android that i plan to work on after vacation, such as Duplicate icon and this icon size.

kouloughli-hemza · 2024-11-25T17:43:11Z

you can try https://www.npmjs.com/package/nixa-expo-dynamic-app-icon new version for android duplicate icon issue

Update android build.gradle

cad0305

adamhari mentioned this pull request Mar 1, 2024

Expo SDK 50 compatibility #17

Open

Simon added 2 commits March 15, 2024 23:44

use intent filters from main activity

a1d36ab

revert to default intent filter if main activity filters cant be used

9fc1816

simonsturge changed the title ~~Update android build.gradle~~ Expo SDK 50 & Android deep link fix Mar 16, 2024

simonsturge mentioned this pull request Mar 16, 2024

This breaks deep linking using custom scheme #11

Open

apply changes from PR 15

acfd738

castdrian mentioned this pull request Mar 19, 2024

no functionality when built via xcodebuild #20

Closed

Simon added 2 commits March 23, 2024 18:50

added platforms array to optionally remove support for one platform (…

1c1178d

…user may want to use adaptive icons built into expo)

removed the logging

0dab95d

castdrian mentioned this pull request Mar 30, 2024

Gradle build fails for android because of this package (works fine on iOS) #22

Open

lxp-git approved these changes Jun 21, 2024

View reviewed changes

theblondealex approved these changes Jun 21, 2024

View reviewed changes

lorenzogonnelli approved these changes Jun 25, 2024

View reviewed changes

apokusin mentioned this pull request Aug 26, 2024

EXPO SDK 51 COMPATIBILITY #26

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expo SDK 50 & Android deep link fix #18

Expo SDK 50 & Android deep link fix #18

simonsturge commented Feb 24, 2024

adamhari commented Mar 1, 2024

simonsturge commented Mar 16, 2024

apokusin commented Mar 18, 2024

Elue-dev commented Mar 31, 2024

theblondealex commented Apr 9, 2024

theblondealex commented Apr 9, 2024

simonsturge commented Apr 9, 2024

Elue-dev commented Apr 9, 2024

theblondealex commented Apr 9, 2024

simonsturge commented Apr 9, 2024

Elue-dev commented Apr 9, 2024 •

edited

Loading

simonsturge commented Apr 9, 2024

theblondealex commented Apr 12, 2024

Elue-dev commented Apr 12, 2024

theblondealex commented Apr 12, 2024 •

edited

Loading

SunlightLuck commented Apr 22, 2024 •

edited

Loading

apokusin commented Apr 22, 2024

SunlightLuck commented Apr 22, 2024

apokusin commented Apr 23, 2024 •

edited

Loading

SunlightLuck commented Apr 23, 2024

apokusin commented Apr 23, 2024 •

edited

Loading

beau6183 commented Jun 13, 2024

apokusin commented Jun 13, 2024

kouloughli-hemza commented Jun 18, 2024

Elue-dev commented Jun 21, 2024 •

edited

Loading

crumb1e commented Jul 8, 2024

kouloughli-hemza commented Jul 8, 2024

Wilson-Lim commented Sep 2, 2024

kouloughli-hemza commented Sep 12, 2024 •

edited

Loading

thedev132 commented Sep 15, 2024

kouloughli-hemza commented Sep 16, 2024

kouloughli-hemza commented Nov 25, 2024

Expo SDK 50 & Android deep link fix #18

Are you sure you want to change the base?

Expo SDK 50 & Android deep link fix #18

Conversation

simonsturge commented Feb 24, 2024

adamhari commented Mar 1, 2024

simonsturge commented Mar 16, 2024

apokusin commented Mar 18, 2024

Elue-dev commented Mar 31, 2024

theblondealex commented Apr 9, 2024

theblondealex commented Apr 9, 2024

simonsturge commented Apr 9, 2024

Elue-dev commented Apr 9, 2024

theblondealex commented Apr 9, 2024

simonsturge commented Apr 9, 2024

Elue-dev commented Apr 9, 2024 • edited Loading

simonsturge commented Apr 9, 2024

theblondealex commented Apr 12, 2024

Elue-dev commented Apr 12, 2024

theblondealex commented Apr 12, 2024 • edited Loading

SunlightLuck commented Apr 22, 2024 • edited Loading

apokusin commented Apr 22, 2024

SunlightLuck commented Apr 22, 2024

apokusin commented Apr 23, 2024 • edited Loading

SunlightLuck commented Apr 23, 2024

apokusin commented Apr 23, 2024 • edited Loading

beau6183 commented Jun 13, 2024

apokusin commented Jun 13, 2024

kouloughli-hemza commented Jun 18, 2024

Elue-dev commented Jun 21, 2024 • edited Loading

crumb1e commented Jul 8, 2024

kouloughli-hemza commented Jul 8, 2024

Wilson-Lim commented Sep 2, 2024

kouloughli-hemza commented Sep 12, 2024 • edited Loading

thedev132 commented Sep 15, 2024

kouloughli-hemza commented Sep 16, 2024

kouloughli-hemza commented Nov 25, 2024

Elue-dev commented Apr 9, 2024 •

edited

Loading

theblondealex commented Apr 12, 2024 •

edited

Loading

SunlightLuck commented Apr 22, 2024 •

edited

Loading

apokusin commented Apr 23, 2024 •

edited

Loading

apokusin commented Apr 23, 2024 •

edited

Loading

Elue-dev commented Jun 21, 2024 •

edited

Loading

kouloughli-hemza commented Sep 12, 2024 •

edited

Loading