Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume unit behavior as units of length #21459

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Volume unit behavior as units of length #21459

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0fd2a9
Volume unit behavior as units of length
0xRe1nk0 Nov 27, 2024
7660caf
Merge branch 'refs/heads/master' into volume_units_behavior
Chumva Dec 19, 2024
42d99d2
Try to fix #21459
Chumva Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions OsmAnd/src/net/osmand/plus/settings/backend/OsmandSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,6 +1047,7 @@ public boolean setValue(Object prefs, DrivingRegion val) {
boolean overrideMetricSystem = !DRIVING_REGION_AUTOMATIC.getValue(prefs, DRIVING_REGION_AUTOMATIC.getDefaultValue());
if (overrideMetricSystem && val != null) {
METRIC_SYSTEM.setValue(prefs, val.defMetrics);
UNIT_OF_VOLUME.set(val.volumeUnit);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect, driving region should override only default value. If the value is set by user it should never be overridden

Copy link
Member

@Chumva Chumva Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshcherb Do we still need to change the preference for METRIC_SYSTEM here, or is it fine to remove it?

}
return super.setValue(prefs, val);
}
Expand Down
Loading