Volume unit behavior as units of length #21459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshcherb
reviewed
Nov 27, 2024
| @@ -1047,6 +1047,7 @@ public boolean setValue(Object prefs, DrivingRegion val) { | |||
| boolean overrideMetricSystem = !DRIVING_REGION_AUTOMATIC.getValue(prefs, DRIVING_REGION_AUTOMATIC.getDefaultValue()); | |||
| if (overrideMetricSystem && val != null) { | |||
| METRIC_SYSTEM.setValue(prefs, val.defMetrics); | |||
| UNIT_OF_VOLUME.set(val.volumeUnit); | |||
There was a problem hiding this comment.
Incorrect, driving region should override only default value. If the value is set by user it should never be overridden
There was a problem hiding this comment.
@vshcherb Do we still need to change the preference for METRIC_SYSTEM here, or is it fine to remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.