Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent all test-runners from using node v18.17.0 #909

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

ZeLonewolf
Copy link
Member

@ZeLonewolf ZeLonewolf commented Jul 31, 2023

Node v18.17.0, released on July 18, 2023, introduced a bug which breaks one test case as shown in PR #905 and debugged in PR #908.

This PR forces node v18.16.0 in the Ubuntu CI runner.

I implemented this PR in two commits to demonstrate that the Ubuntu runner is in fact currently broken on node "18.x".

@github-actions
Copy link

PR Preview:

Sprite Sheets:

Sprites 1x
Sprites 2x

@zekefarwell
Copy link
Collaborator

Nice sleuthing! I have Node 18.17 on my Mac and get the same test failure as the test-build-ubuntu workflow. I installed Node 18.16.1 and can confirm that the test passes when run with that version. I also installed Node 20.5.0 (released the same day as 18.17) and found that the test fails with the same error.

Holding the test workflow back to 18.16.1 seems like a good idea for now. Seems like it would be good to do the same on the test-build-mac workflow too. So far that one seems to still be using a cached version on 18.16.1, but I imagine it will bump up to 18.17 at some point soon and then the test will start failing there as well.

@ZeLonewolf ZeLonewolf changed the title Prevent the ubuntu test-runner from using node v18.17.0 Prevent all test-runners from using node v18.17.0 Aug 1, 2023
@ZeLonewolf
Copy link
Member Author

Updated the PR to change the fallback to 18.16.1 and apply it to all CI runners.

Copy link
Collaborator

@zekefarwell zekefarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good solution for now.

@ZeLonewolf ZeLonewolf merged commit fe3376d into main Aug 1, 2023
@ZeLonewolf ZeLonewolf deleted the zlw-force-node-18.16 branch August 1, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants