Merge pull request #909 from ZeLonewolf/zlw-force-node-18.16

Prevent all test-runners from using node v18.17.0
osm-americana · Aug 1, 2023 · fe3376d · fe3376d
2 parents efff6cd + 8d65b3d
commit fe3376d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 8 deletions.
diff --git a/.github/workflows/build-preview.yml b/.github/workflows/build-preview.yml
@@ -19,10 +19,10 @@ jobs:
     steps:
       - name: Checkout 🛎️
         uses: actions/checkout@v3
-      - name: Use Node.js 18.x
+      - name: Use Node.js 18.16.1
         uses: actions/setup-node@v3
         with:
-          node-version: 18.x
+          node-version: 18.16.1 #18.17.0 is buggy
       - name: Save PR number
         env:
           PR_NUMBER: ${{ github.event.pull_request.number }}

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -20,10 +20,10 @@ jobs:
     steps:
       - name: Checkout 🛎️
         uses: actions/checkout@v3
-      - name: Use Node.js 18.x
+      - name: Use Node.js 18.16.1
         uses: actions/setup-node@v3
         with:
-          node-version: 18.x
+          node-version: 18.16.1 #18.17.0 is buggy
       - name: Install and Build 🔧
         run: |
           npm ci --include=dev

diff --git a/.github/workflows/test-build-mac.yml b/.github/workflows/test-build-mac.yml
@@ -10,10 +10,13 @@ jobs:
     steps:
       - name: Checkout 🛎️
         uses: actions/checkout@v3
-      - name: Use Node.js 18.x
+# Node v18.17.0, introduced July 18, 2023, introduces an error in unicode processing that breaks test cases on Ubuntu.
+# See PR #905 and #908 for more details.
+# If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.0.
+      - name: Use Node.js 18.16.1
         uses: actions/setup-node@v3
         with:
-          node-version: 18.x
+          node-version: 18.16.1
       - name: Build Shield Library 🛡️
         run: |
           cd shieldlib

diff --git a/.github/workflows/test-build-ubuntu.yml b/.github/workflows/test-build-ubuntu.yml
@@ -10,10 +10,13 @@ jobs:
     steps:
       - name: Checkout 🛎️
         uses: actions/checkout@v3
-      - name: Use Node.js 18.x
+# Node v18.17.0, introduced July 18, 2023, introduces an error in unicode processing that breaks test cases on Ubuntu.
+# See PR #905 and #908 for more details.
+# If this bug is resolved in node, these lines can revert to 18.x rather than 18.16.1.
+      - name: Use Node.js 18.16.1
         uses: actions/setup-node@v3
         with:
-          node-version: 18.x
+          node-version: 18.16.1
       - name: Build Shield Library 🛡️
         run: |
           cd shieldlib