Ubuntu CI test only #908
Ubuntu CI test only #908
Conversation
…ility Specifying the `main`, `module`, and `browser` options in package.json should allow the proper format to be selected by the importing context.
…module resolution issue ts-node is importing the common js module build rather than the esmodule build, but treating it as an esmodule. This leads to name resolution errors. importing the typescript source file instead of the build output works around this issue.
…e resolution issue ts-node is importing the common js module build rather than the esmodule build, but treating it as an esmodule. This leads to name resolution errors. importing the typescript source file instead of the build output works around this issue.
|
PR Preview: Sprite Sheets:
|
| name: "L'Aquila", | ||
| "name:en": "L’Aquila", | ||
| }; | ||
| it("L'Aquila special case 1", function () { |
There was a problem hiding this comment.
Test case names should read like sentences describing the intended result.
| !isMultiName && | ||
| diacriticInsensitiveCaseInsensitiveSubstring(localized, local) | ||
| ) { | ||
| //Québec + Quebec City = Québec City case |
There was a problem hiding this comment.
Reimplementing the expressions in imperative JavaScript is an interesting exercise, but I don’t think it can replace the existing tests that verify the expected results directly. It ends up being more surface area that itself needs to be tested. Our objective is to ensure the expression evaluates to “Québec City” for user display, not that MapLibre implements these expressions using particular JavaScript functions.
|
Just to be clear, I'm primarily using this PR as a vehicle to identify the cause of the test case failure, since it only seems to be a problem on the CI system. |
PR for the purpose of debugging PR #905 CI tests.