-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PR preview to Checks tab and add statistics #881
Conversation
5251825
to
1d1c634
Compare
Maybe add a comment in scripts/stats.js or in its output expressing in words that this is the length of the serialized style JSON. |
Added in 14d4403 |
Sample output, from the github actions log: Style size statistics
Layer count comparison
Layer size comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what’s going on with the random links unfortunately. Apparently something is getting piped through an environment where GitHub Actions is parsing content to autolink it.
I manually copy/pasted the content from the output log of the github action, so that may or may not occur when the github action does the writing. |
From some testing, it's happening at the browser/paste level so probably ignorable. |
1d1affd
to
b9551db
Compare
The random linking issue does not occur when writing directly to the Checks tab. |
PR Preview: Sprite Sheets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not seeing the statistics in the Checks tab. Is it dependent on merging to main?
Never mind, I missed this in the Check tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I’ll be glad to see this information go in the Checks tab rather than spam the comments.
This PR adds statistics to the checks tab, which will show the change in layer size.
Additionally, this moves the PR Preview comment into the checks tab, to avoid email spamming.