Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style benchmark #883

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Add style benchmark #883

merged 7 commits into from
Jun 21, 2023

Conversation

msbarry
Copy link
Contributor

@msbarry msbarry commented Jun 20, 2023

Add a benchmark that evaluates each transportation style layer filter expression on each transportation feature in a few tiles.

On my machine I'm seeing:

❯ node scripts/benchmark.js     
(node:84076) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
122.5ms evaluate expressions nyc z12 x 8.16 ops/sec ±0.25% (25 runs sampled)
108.0ms evaluate expressions boston z12 x 9.26 ops/sec ±0.11% (28 runs sampled)
0.1506ms evaluate expressions kansas z14 x 6,642 ops/sec ±0.22% (101 runs sampled)

@ZeLonewolf
Copy link
Member

Awesome! Workflows are currently in a broken state pending #879 but once that's resolved, we can incorporate this into the ongoing work (#881) to automatically generate PR statistics.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together!

@github-actions
Copy link

PR Preview:

Sprite Sheets:

Sprites 1x
Sprites 2x

@ZeLonewolf ZeLonewolf merged commit 9eb5b36 into osm-americana:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants