Add museum icon and brown "attraction" POI color #857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #820, and makes progress on #692 (well, actually museums aren't explicitly listed in #692, but they probably should be). I've used a modified version of the columned, neoclassical building I originally proposed for town halls in #794, but without the flag:
This icon specifically evokes the large, established institutions of big cities, but I think the symbol is recognizable enough to represent museums of diverse sizes and settings.
This is the first POI in the "attraction" category, so the PR also adds and documents a new POI color, "attraction brown". Brown was suggested in #128, and it seems reasonable for attractions based on American usage, such as MUTCD signage. As @1ec5 pointed out on Slack, care may be needed when indigenous land boundaries are added (#105) to make sure the colors in the style clearly communicate their intended meaning. I've reused the brown color defined for highways, hex #693F23, but would be amenable to alterations if someone has a strong opinion.
Samples:
National Mall (localhost):
Woods Hole, MA (localhost):
San Francisco, CA (localhost):
Chicago, IL (localhost):
Note that the Field Museum (
tourism=museum
) is rendered in this PR, but the Shedd Aquarium (tourism=aquarium
OMT class=aquarium, subclass=aquarium) and the Adler Planetarium (amenity=planetarium
, which doesn't appear to be in OMT, although I think this might be a tagging error) are not.