Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add museum icon and brown "attraction" POI color #857

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

wmisener
Copy link
Collaborator

Fixes #820, and makes progress on #692 (well, actually museums aren't explicitly listed in #692, but they probably should be). I've used a modified version of the columned, neoclassical building I originally proposed for town halls in #794, but without the flag:

poi_museum

This icon specifically evokes the large, established institutions of big cities, but I think the symbol is recognizable enough to represent museums of diverse sizes and settings.

This is the first POI in the "attraction" category, so the PR also adds and documents a new POI color, "attraction brown". Brown was suggested in #128, and it seems reasonable for attractions based on American usage, such as MUTCD signage. As @1ec5 pointed out on Slack, care may be needed when indigenous land boundaries are added (#105) to make sure the colors in the style clearly communicate their intended meaning. I've reused the brown color defined for highways, hex #693F23, but would be amenable to alterations if someone has a strong opinion.

Samples:
National Mall (localhost):
Screen Shot 2023-04-11 at 8 25 55 AM

Woods Hole, MA (localhost):
Screen Shot 2023-04-11 at 8 28 57 AM

San Francisco, CA (localhost):
Screen Shot 2023-04-11 at 8 31 16 AM

Chicago, IL (localhost):
Screen Shot 2023-04-11 at 8 42 40 AM
Note that the Field Museum (tourism=museum) is rendered in this PR, but the Shedd Aquarium (tourism=aquarium OMT class=aquarium, subclass=aquarium) and the Adler Planetarium (amenity=planetarium, which doesn't appear to be in OMT, although I think this might be a tagging error) are not.

Icon, add to layer, new attraction color
Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual inspection and code looks good to me. I'm glad we could re-use the work on this. Like to get someone on one of the fancier displays to make sure it looks good at all resolutions.

Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ZeLonewolf ZeLonewolf merged commit d57077e into osm-americana:main Apr 12, 2023
@wmisener wmisener deleted the wmisener/museum branch April 12, 2023 02:59
@wmisener wmisener mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render museums
3 participants