Merge pull request #857 from wmisener/wmisener/museum

Add museum icon and brown "attraction" POI color
osm-americana · Apr 12, 2023 · d57077e · d57077e
2 parents a5ea134 + 33dccbc
commit d57077e
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 3 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -376,7 +376,7 @@ For consistency, POI icons use the following color palette:
 | Infrastructure         | Pantone 294     | <img src="doc-img/pantone_294.svg" height=18 width=50 /> Blue               | 0 63 135    | #003f87     |
 | Consumer               | UTexas Orange   | <img src="doc-img/texas_orange.svg" height=18 width=50 /> Orange            | 191 87 0    | #bf5700     |
 | Outdoor                |                 | TBD (green?)                                                                |             |             |
-| Attraction             |                 | TBD (brown?)                                                                |             |             |
+| Attraction             | Pantone 469     | <img src="doc-img/pantone_469.svg" height=18 width=50 /> Brown              | 105 63 35   | #693f23     |
 | Airport                | Medium Purple C | <img src="doc-img/pantone_medium_purple_c.svg" height=18 width=50 /> Purple | 78 0 142    | #4e008e     |
 | Transport              | Pantone 234 C   | <img src="doc-img/pantone_234_c.svg" height=18 width=50 /> Mauve            | 162 0 103   | #a20067     |
 | Knockout               |                 | <img src="doc-img/background.svg" height=18 width=50 /> Lt Grayish Orange   | 249 245 240 | #f9f5f0     |
diff --git a/icons/poi_museum.svg b/icons/poi_museum.svg
diff --git a/scripts/taginfo_template.json b/scripts/taginfo_template.json
@@ -463,6 +463,15 @@
       "doc_url": "https://openmaptiles.org/schema/#poi",
       "icon_url": "https://raw.githubusercontent.com/ZeLonewolf/openstreetmap-americana/main/icons/poi_town_hall.svg"
     },
+    {
+      "key": "tourism",
+      "value": "museum",
+      "object_types": ["node", "area"],
+      "description": "Museums are marked by an icon representing a Classical columned building.",
+      "doc_url": "https://openmaptiles.org/schema/#poi",
+      "icon_url": "https://raw.githubusercontent.com/ZeLonewolf/openstreetmap-americana/main/icons/poi_museum.svg"
+    },
+
     {
       "key": "amenity",
       "value": "clinic",

diff --git a/src/constants/color.js b/src/constants/color.js
@@ -81,7 +81,7 @@ export const poi = {
   infrastructure: palette.blue,
   consumer: palette.texas_orange,
   //outdoor:
-  //attraction:
+  attraction: palette.brown,
   airport: `hsl(${hue.airport}, 100%, 28%)`,
   transport: palette.mauve,
 };
diff --git a/src/layer/poi.js b/src/layer/poi.js
@@ -52,6 +52,14 @@ var iconDefs = {
     color: Color.poi.infrastructure,
     description: "Doctor's office or clinic",
   },
+  museum: {
+    classes: {
+      museum: ["museum"],
+    },
+    sprite: "poi_museum",
+    color: Color.poi.attraction,
+    description: "Museum",
+  },
   parking: {
     classes: {
       parking: ["parking"],
@@ -152,6 +160,8 @@ export const poi = {
         ...getSubclasses(iconDefs.railway_stop),
       ],
       Color.poi.transport,
+      ["museum"],
+      Color.poi.attraction,
       ["hospital", "parking", "school", "townhall"],
       Color.poi.infrastructure,
       Color.poi.infrastructure,
@@ -170,9 +180,10 @@ export const poi = {
       [
         "bus_stop",
         "hospital",
-        "tram_stop",
+        "museum",
         ...getSubclasses(iconDefs.school),
         "townhall",
+        "tram_stop",
       ],
       15,
       [...getSubclasses(iconDefs.bar), ...getSubclasses(iconDefs.coffee)],