Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js in CI #1166

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Update Node.js in CI #1166

merged 6 commits into from
Dec 5, 2024

Conversation

jleedev
Copy link
Member

@jleedev jleedev commented Nov 14, 2024

Switch from 18.x (maintenance LTS until next spring) to 20.x (maintenance LTS for a year past that).

Rather than repeating the version in every workflow, reference the tool version by filename.

Rather than specifying an exact major version, give actions/setup-node a range of major versions.

The node-canvas dependency has prebuilt binaries for up to node 20, so limit to that in engines. They have a version 3 release candidate that switches to N-API, which is a more stable interface that will ultimately avoid a lot of this trouble.

Because of the .npmrc, this will cause npm install to loudly fail on an unsupported version, even if one is willing to e.g. build node-canvas from source. Do --no-engine-strict or npm_config_engine_strict=false in the environment to ignore this.

jleedev and others added 5 commits November 14, 2024 10:59
Switch from 18.x (maintenance LTS until next spring) to 22.x (active LTS
for the coming year).

Rather than repeating the version in every workflow, reference the tool
version by filename.

Rather than specifying an exact major version, allow actions/setup-node
to use a version that matches the requirement of ">=18", which is likely
to require adjusting this less often (assuming things don't break by
surprise when the version changes).
Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ZeLonewolf ZeLonewolf merged commit a0c86a3 into main Dec 5, 2024
6 checks passed
@ZeLonewolf ZeLonewolf deleted the jleedev-fiddle-workflow branch December 5, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants