Skip to content

Commit

Permalink
Merge pull request #1166 from osm-americana/jleedev-fiddle-workflow
Browse files Browse the repository at this point in the history
Update Node.js in CI
  • Loading branch information
ZeLonewolf authored Dec 5, 2024
2 parents 6897ae3 + 08f976f commit a0c86a3
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ jobs:
build-preview:
runs-on: ubuntu-latest
steps:
- name: Use Node.js 18.x
uses: actions/setup-node@v4
with:
node-version: 18.x
- name: Checkout Main Branch 🛎️
uses: actions/checkout@v4
with:
Expand All @@ -31,6 +27,10 @@ jobs:
uses: actions/checkout@v4
with:
path: pr-branch
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version-file: pr-branch/package.json
- name: Install and Build Main Branch 🔧
run: |
npm ci --include=dev
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
steps:
- name: Checkout 🛎️
uses: actions/checkout@v4
- name: Use Node.js 18.x
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version-file: package.json
- name: Install and Build 🔧
# TODO: when we move shieldlib to its own repo, move shieldlib docs CI also
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
# This is important to fetch the changes to the previous commit
fetch-depth: 0

- name: Set up Node.js
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "18" # Specify the Node.js version
node-version-file: package.json

- name: Install dependencies
run: npm install
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-build-macos-13.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
steps:
- name: Checkout 🛎️
uses: actions/checkout@v4
- name: Use Node.js 18.x
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version-file: package.json
- name: Build Shield Library 🛡️
run: |
cd shieldlib
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-build-ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
steps:
- name: Checkout 🛎️
uses: actions/checkout@v4
- name: Use Node.js 18.x
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version-file: package.json
- name: Build Shield Library 🛡️
run: |
cd shieldlib
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,6 @@
},
"engines": {
"npm": ">=8.3.0",
"node": ">=18"
"node": ">=18 <=20"
}
}

0 comments on commit a0c86a3

Please sign in to comment.