Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create parent directory of obj file #99

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Create parent directory of obj file #99

merged 2 commits into from
Dec 29, 2018

Conversation

seraphy
Copy link
Contributor

@seraphy seraphy commented Dec 21, 2018

Before copying OBJ and LIB to the working directory, It is necessary to create their parent directories in advance.

lukaszlenart
lukaszlenart requested changes Dec 21, 2018
View reviewed changes
Copy link
Collaborator

@lukaszlenart lukaszlenart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one tiny issue with indentation

src/main/java/com/akathist/maven/plugins/launch4j/Launch4jMojo.java Outdated Show resolved Hide resolved
@lukaszlenart
Copy link
Collaborator

Looks good, I will merge it and prepare a new release just after Christmas :)

@lukaszlenart
Copy link
Collaborator

osm! LGTM 👍

@lukaszlenart lukaszlenart merged commit 88ede40 into orphan-oss:master Dec 29, 2018
@seraphy seraphy deleted the ensureobjdir branch December 31, 2018 03:45
@seraphy
Copy link
Contributor Author

seraphy commented Dec 31, 2018

arigatou gozaimashita. Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszlenart lukaszlenart lukaszlenart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seraphy @lukaszlenart