Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): remove excessive warning and typo #210

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Dec 20, 2023

Description

Iff one doesn't use auth tokens, their log is spammed with warning messages.
This change removes the warning message.

It also fixes a small typo.

Motivation and Context

Fixes #209

How Has This Been Tested?

cargo test
fixtures

Changelog Entry

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tessus tessus requested a review from orhun as a code owner December 20, 2023 12:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f905648) 70.16% compared to head (e242104) 70.11%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
- Coverage   70.16%   70.11%   -0.05%     
==========================================
  Files          11       11              
  Lines         610      609       -1     
==========================================
- Hits          428      427       -1     
  Misses        182      182              
Flag Coverage Δ
unit-tests 70.11% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tessus
Copy link
Collaborator Author

tessus commented Dec 20, 2023

Something's off with the shuttle deploy action. But I don't think a shuttle version should be deployed when creating a PR. Or is this a test shuttle instance (not prod)?

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@orhun
Copy link
Owner

orhun commented Dec 20, 2023

Something's off with the shuttle deploy action.

Yeah, it shouldn't deploy. I think the following condition is not working:

      - name: Deploy
        if: |
          ${{ startsWith(github.event.ref, 'refs/tags/v') ||
            github.event_name == 'workflow_dispatch' ||
            steps.changes.outputs.manifest == 'true'
          }}

Are you interested in looking into it by any chance?

@orhun orhun changed the title fix(auth): remove excessive warning, typo fix(auth): remove excessive warning and typo Dec 20, 2023
@orhun orhun merged commit ec9b55f into orhun:master Dec 20, 2023
8 of 9 checks passed
@tessus
Copy link
Collaborator Author

tessus commented Dec 20, 2023

I would be, but I do not have a shuttle account. Not sure how to test any changes on my fork.
I might be able to look into it within the next few weeks (I will also have to create a shuttle account and API key). Although during the holidays it's always busy.

@orhun
Copy link
Owner

orhun commented Dec 20, 2023

Alright, no problem. I think it is just enough to test that condition on GitHub Actions. I will just create an immediate release for the changes in this PR now and we can look into that later I guess.

@tessus tessus mentioned this pull request Jan 31, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth logging is too chatty
3 participants