-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): remove excessive warning and typo #210
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 70.16% 70.11% -0.05%
==========================================
Files 11 11
Lines 610 609 -1
==========================================
- Hits 428 427 -1
Misses 182 182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Something's off with the shuttle deploy action. But I don't think a shuttle version should be deployed when creating a PR. Or is this a test shuttle instance (not prod)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Yeah, it shouldn't deploy. I think the following condition is not working:
Are you interested in looking into it by any chance? |
I would be, but I do not have a shuttle account. Not sure how to test any changes on my fork. |
Alright, no problem. I think it is just enough to test that condition on GitHub Actions. I will just create an immediate release for the changes in this PR now and we can look into that later I guess. |
Description
Iff one doesn't use auth tokens, their log is spammed with warning messages.
This change removes the warning message.
It also fixes a small typo.
Motivation and Context
Fixes #209
How Has This Been Tested?
cargo test
fixtures
Changelog Entry
Types of Changes
Checklist: