Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(shuttle): fix deployment #236

Merged
merged 4 commits into from
Feb 6, 2024
Merged

ci(shuttle): fix deployment #236

merged 4 commits into from
Feb 6, 2024

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Jan 31, 2024

Description

This change fixes the attempt to deploy on a PR.

Motivation and Context

see #210 (comment)

How Has This Been Tested?

on my own repo

Changelog Entry

### Changed

- Do not run shuttle deployment on Pull Requests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tessus tessus requested a review from orhun as a code owner January 31, 2024 13:58
@tessus
Copy link
Collaborator Author

tessus commented Jan 31, 2024

of course there is an unrelated (and false, due to network issues) error in another pipeline.

please re-run this pipeline. if the shuttle pipeline is run manually, it would trigger again. I believe that was your original intention with the workflow_dispatch.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8de2450) 70.11% compared to head (a551d22) 70.11%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files          11       11           
  Lines         609      609           
=======================================
  Hits          427      427           
  Misses        182      182           
Flag Coverage Δ
unit-tests 70.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit e06c182 into orhun:master Feb 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants