-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(fixtures): support fixtures
on macOS
#200
Conversation
fixtures
on macOS
Though it might be broken anytime without CI, so if it makes sense I can add a matrix with OS Probably it's not a desired approach to time fixtures, taking other platforms into account |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 70.23% 70.23%
=======================================
Files 11 11
Lines 598 598
=======================================
Hits 420 420
Misses 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yeah, I think it is a good idea to add a matrix here: rustypaste/.github/workflows/ci.yml Line 47 in 3e34206
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just add a comment there 🐻
Co-authored-by: Orhun Parmaksız <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
fixtures
on macOS
fixtures
on macOS
Description
Change fixtures to support macos as well as linux
Motivation and Context
sleep
doesn't work with time-units (e.gsleep 1s
)fallocate
(dd if=/dev/random of=normalfile count=10000 bs=1024 status=none
used)"$(curl -s -H "Authorization: $auth_token" localhost:8000/list | grep -o 'file_name' | wc -l)"
returns" 3"
, so it's not equal to"3"
How Has This Been Tested?
Fixtures works on macOS and should pass CI (on lunux)
Changelog Entry
Types of Changes
Checklist: