Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fixtures): run fixtures on macos & ubuntu #201

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

DDtKey
Copy link
Contributor

@DDtKey DDtKey commented Dec 10, 2023

Description

Added matrix to CI in order to check the fixtures works on both OS

Motivation and Context

macos is pretty common OS and can be compatible with testing framework

In continuation of #200

How Has This Been Tested?

Changelog Entry

### Added

- Check fixtures against MacOS in CI

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other Testing

Checklist:

  • [] My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

In order to check the fixtures works on both OS
@DDtKey DDtKey requested a review from orhun as a code owner December 10, 2023 16:51
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adbd67a) 70.23% compared to head (a698d03) 70.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   70.23%   70.23%           
=======================================
  Files          11       11           
  Lines         598      598           
=======================================
  Hits          420      420           
  Misses        178      178           
Flag Coverage Δ
unit-tests 70.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun changed the title ci(fixtures): run fixtures on macos & ubuntu chore(fixtures): run fixtures on macos & ubuntu Dec 11, 2023
@orhun orhun merged commit c5c9c6d into orhun:master Dec 11, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants