-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doubling kubeval check memory limits and requires #2289
doubling kubeval check memory limits and requires #2289
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@Gregory-Pereira: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Not sure why this test is failing, logs (available here) state that:
|
@Gregory-Pereira this fail is expected because you are changing only |
@mimotej as this is a valid pr, and expected type of change, we should note that the ci check should account for this and not fail -- can you capture this in an issue? |
Temporarily addresses: #2288
/cc @HumairAK
/cc @mimotej