Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doubling kubeval check memory limits and requires #2289

Merged

Conversation

Gregory-Pereira
Copy link
Member

Temporarily addresses: #2288
/cc @HumairAK
/cc @mimotej

@sesheta sesheta requested review from HumairAK and mimotej August 24, 2022 18:45
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2022
@sesheta
Copy link
Member

sesheta commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from gregory-pereira after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gregory-Pereira
Copy link
Member Author

/retest

@sesheta
Copy link
Member

sesheta commented Aug 24, 2022

@Gregory-Pereira: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/kustomize-build eb23223 link true /test kustomize-build
aicoe-ci/prow/kubeval-validation eb23223 link true /test kubeval-validation

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Gregory-Pereira
Copy link
Member Author

Gregory-Pereira commented Aug 24, 2022

Not sure why this test is failing, logs (available here) state that:

Checking changes in range 240605ab587cdd44eb1bf64b54855b4c39c2e60e..eb2322361b550d28de704acae039ed236c6ef30e only.
Aborting due to errexit on line 11. Exit code: 1
Aborting due to errexit on line 11. Exit code: 1
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2022-08-24T18:46:23Z"}

@mimotej
Copy link
Member

mimotej commented Aug 24, 2022

Not sure why this test is failing, logs (available here) state that:

Checking changes in range 240605ab587cdd44eb1bf64b54855b4c39c2e60e..eb2322361b550d28de704acae039ed236c6ef30e only.
Aborting due to errexit on line 11. Exit code: 1
Aborting due to errexit on line 11. Exit code: 1
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2022-08-24T18:46:23Z"}

@Gregory-Pereira this fail is expected because you are changing only .prow.yaml and script checks if there are changes in manifests which are related to clusters, it finds none and grep fails. Therefore these errors can be safely ignored

@HumairAK
Copy link
Member

Therefore these errors can be safely ignored

@mimotej as this is a valid pr, and expected type of change, we should note that the ci check should account for this and not fail -- can you capture this in an issue?

@HumairAK HumairAK merged commit 5f1e562 into operate-first:master Aug 24, 2022
@mimotej
Copy link
Member

mimotej commented Aug 25, 2022

Therefore these errors can be safely ignored

@mimotej as this is a valid pr, and expected type of change, we should note that the ci check should account for this and not fail -- can you capture this in an issue?

@HumairAK Done ✔️ #2294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants