Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI checks are run on on yaml manifests that are not part of cluster #2294

Closed
1 task
mimotej opened this issue Aug 25, 2022 · 2 comments
Closed
1 task

CI checks are run on on yaml manifests that are not part of cluster #2294

mimotej opened this issue Aug 25, 2022 · 2 comments
Assignees

Comments

@mimotej
Copy link
Member

mimotej commented Aug 25, 2022

In following PR there was a change in .prow.yaml which should not trigger kustomize-build and kubeval-validation jobs. These jobs were triggered and it let to failure of these tests. We should try to address that.

Acceptance criteria

  • kustomize-build and kubeval-validation are not triggered when changing files which are not part of the clusters or they end without failling
@durandom
Copy link
Member

@mimotej if you have a quick fix, can you add it to to config? Maybe a path filter or something?
If not, I would not care too much, since changes to those yaml files rarely happen.

feel free to close it without a resolution :)

/assign @mimotej

@mimotej
Copy link
Member Author

mimotej commented Sep 26, 2022

@durandom This was somewhat addressed in #2321 . I don't think there is a simple change in actual script to fix this and current change in prow seems to work just fine. So we can close this for now...

@mimotej mimotej closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants