Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle videos iframes and add visual indicator of external links #43

Merged
merged 4 commits into from
Oct 29, 2024

Always indicate iframe link when we do not know how to fetch image pl…

52559e6
Select commit
Loading
Failed to load commit list.
Merged

Handle videos iframes and add visual indicator of external links #43

Always indicate iframe link when we do not know how to fetch image pl…
52559e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 28, 2024 in 0s

38.44% (-1.10%) compared to a732a8a

View this Pull Request on Codecov

38.44% (-1.10%) compared to a732a8a

Details

Codecov Report

Attention: Patch coverage is 27.27273% with 40 lines in your changes missing coverage. Please review.

Project coverage is 38.44%. Comparing base (a732a8a) to head (52559e6).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 19.44% 29 Missing ⚠️
scraper/src/mindtouch2zim/vimeo.py 31.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   39.54%   38.44%   -1.10%     
==========================================
  Files           8        9       +1     
  Lines         612      658      +46     
  Branches       71       80       +9     
==========================================
+ Hits          242      253      +11     
- Misses        368      403      +35     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.