Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle videos iframes and add visual indicator of external links #43

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Oct 25, 2024

Fix #24
Fix #42
Fix #45

See list of commits for details about changes, they are meant to be self explanatory

Nota: requires yet another change in python-scraperlib HTML rewriting engine, see openzim/python-scraperlib#209

Not ready to review because I should also work on #45 as well in same PR so that it is more obvious

@benoit74 benoit74 self-assigned this Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 40 lines in your changes missing coverage. Please review.

Project coverage is 38.44%. Comparing base (a732a8a) to head (52559e6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 19.44% 29 Missing ⚠️
scraper/src/mindtouch2zim/vimeo.py 31.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   39.54%   38.44%   -1.10%     
==========================================
  Files           8        9       +1     
  Lines         612      658      +46     
  Branches       71       80       +9     
==========================================
+ Hits          242      253      +11     
- Misses        368      403      +35     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from title_favicon to main October 28, 2024 10:04
@benoit74 benoit74 marked this pull request as ready for review October 28, 2024 10:44
@benoit74 benoit74 requested a review from rgaudin October 28, 2024 10:45
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; see question

scraper/src/mindtouch2zim/processor.py Show resolved Hide resolved
@benoit74 benoit74 merged commit 118dab7 into main Oct 29, 2024
10 checks passed
@benoit74 benoit74 deleted the handle_videos_iframes branch October 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants