Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connection not deleted after connectionless proof #995

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Oct 12, 2023

Summary of Changes

Previously during a connectionless proof, if the verifier closes the app or goes to the home screen before the holder sends their presentation, then if the verifier open the proof notification from the home screen and then leaves the proof notification page then the connection would be preserved.

I've altered the functionality so that the connection will always be deleted after viewing a connectionless proof, regardless of where the proof is viewed
retention

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@wadeking98 wadeking98 requested a review from a team as a code owner October 12, 2023 17:50
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #995 (6db067c) into main (840a64b) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   59.20%   59.17%   -0.03%     
==========================================
  Files         176      176              
  Lines        5091     5095       +4     
  Branches     1454     1456       +2     
==========================================
+ Hits         3014     3015       +1     
- Misses       2051     2054       +3     
  Partials       26       26              
Files Coverage Δ
packages/legacy/core/App/screens/ProofDetails.tsx 71.05% <50.00%> (-0.57%) ⬇️
...ckages/legacy/core/App/screens/ProofRequesting.tsx 67.64% <0.00%> (-2.05%) ⬇️

@wadeking98 wadeking98 merged commit 13c376f into openwallet-foundation:main Oct 12, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants