Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection stays even when data retention turned off #1529

Closed
3 of 5 tasks
knguyenBC opened this issue Oct 11, 2023 · 5 comments
Closed
3 of 5 tasks

Connection stays even when data retention turned off #1529

knguyenBC opened this issue Oct 11, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@knguyenBC
Copy link

knguyenBC commented Oct 11, 2023

Description of problem

When the verifier's phone falls asleep or leaves the mobile verification flow before the information is sent over. The verifier can go back into Contacts and see a connection with the holder and review information.

Expected behavior

When data retention is off, Connection/Contact should be deleted after the information is reviewed.

Steps to reproduce

  • verifier sends a proof request
  • holder scans proof request
  • verifier puts app to sleep or navigate back to home
  • holder accepts the proof request
  • Holder successfully sends information
  • Wake the verifier's phone or go to contact list
  • Open the holder chat
  • Open the information sent over
  • See that the information sent over is gone but the connection stays

Screenshots and/or log output

Environment

  • Occurs on Android
  • Occurs on iOS

Build #: 1246

Android Device Model: Oneplus 6

iOS Device Model: iPhone SE

Workaround

  • Turn off sleep mode

Severity

  • High
  • Medium
  • Low
@knguyenBC knguyenBC added the bug Something isn't working label Oct 11, 2023
@wadeking98 wadeking98 self-assigned this Oct 12, 2023
@wadeking98
Copy link
Contributor

Resolved by: openwallet-foundation/bifold-wallet#995

@jeffaudette
Copy link

needs re-test

@knguyenBC
Copy link
Author

@wadeking98 Connection still stays if the lawyer declines the proof request (works fine if the lawyer accepts). Also, when the lawyer rejects the proof request, if the lawyer is in some other screen, it doesn't display a new message notification in the notification list.

@wadeking98
Copy link
Contributor

got it, I'll fix for instance where proof is declined

@wadeking98
Copy link
Contributor

Resolved by: openwallet-foundation/bifold-wallet#997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants