Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oca credential formatter now returns all attributes #1042

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: oca credential formatter now returns all attributes #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/oca/src/formatters/credential/LocalizedCredential.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,8 @@ export default class LocalizedCredential {

this.attributes =
credentialAttributes
?.filter((attribute) => bundle.getFlaggedAttribute(attribute.name))
.map((attribute) => {
const overlayOptions = bundle.getAttribute(attribute.name) ?? { name: attribute.name, type: '' }
return new DisplayAttribute(attribute, overlayOptions, language)
}) ?? []
?.filter((attribute) => bundle.getAttribute(attribute.name))
.map((attribute) => new DisplayAttribute(attribute, { name: attribute.name, type: '' }, language)) ?? []
}

get primaryAttribute(): DisplayAttribute | undefined {
Expand Down
4 changes: 2 additions & 2 deletions packages/oca/src/formatters/credential/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import CredentialFromatter from './CredentialFormatter'
import CredentialFormatter from './CredentialFormatter'
import DisplayAttribute from './DisplayAttribute'
import LocalizedCredential from './LocalizedCredential'

export { CredentialFromatter, DisplayAttribute, LocalizedCredential }
export { CredentialFormatter, DisplayAttribute, LocalizedCredential }