Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oca credential formatter now returns all attributes #1042

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

amanji
Copy link
Contributor

@amanji amanji commented Dec 6, 2023

Summary of Changes

Previously the credential formatter in the OCA package was filtering attributes by flagged attributes in the capture base. The PR corrects that issue so that all attributes are returned by the credential formatter. This also fixes a secondary issue where attributes were not being returned at all by an additional filter.

Related Issues

Fixes: bcgov/aries-oca-explorer#3

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@amanji amanji self-assigned this Dec 6, 2023
@amanji amanji marked this pull request as ready for review December 6, 2023 17:01
@amanji amanji requested a review from a team as a code owner December 6, 2023 17:01
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8dac14) 61.35% compared to head (6efc80e) 61.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1042   +/-   ##
=======================================
  Coverage   61.35%   61.35%           
=======================================
  Files         170      170           
  Lines        5462     5462           
  Branches     1582     1582           
=======================================
  Hits         3351     3351           
  Misses       2087     2087           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amanji amanji merged commit add2c1a into openwallet-foundation:main Dec 6, 2023
7 checks passed
@amanji amanji deleted the oca-bug-fixes branch June 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only flagged attributes are displayed in detail view
2 participants