Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed order of mobile verifier buttons #1032

Merged

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Nov 23, 2023

Summary of Changes

Changed the order of the mobile verifier options to prioritize requesting another proof instead of going back to the list screen.
image

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14da5e1) 61.30% compared to head (aa54b46) 61.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1032   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files         181      181           
  Lines        5522     5522           
  Branches     1574     1574           
=======================================
  Hits         3385     3385           
  Misses       2113     2113           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach force-pushed the feat-reorder-mobver-buttons branch from 5c4a2f9 to aa54b46 Compare November 23, 2023 21:28
@wadeking98 wadeking98 merged commit 23cd8a4 into openwallet-foundation:main Nov 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants