feat: changed order of mobile verifier buttons (#1032)

Signed-off-by: wadeking98 <[email protected]>
openwallet-foundation · Nov 23, 2023 · 23cd8a4 · 23cd8a4
1 parent 14da5e1
commit 23cd8a4
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 16 deletions.
diff --git a/packages/legacy/core/App/localization/en/index.ts b/packages/legacy/core/App/localization/en/index.ts
@@ -628,6 +628,7 @@ const translation = {
     "Parameterizable": "Parameterizable",
     "RefreshQR": "Refresh QR Code",
     "GenerateNewQR": "Request another proof",
+    "BackToList": "Back to list",
     "ShareLink": "Share link",
     "ScanQR": "Show this QR code to the other person",
     "ScanQRComment": "After the QR code is scanned, a proof request will be sent.",

diff --git a/packages/legacy/core/App/localization/fr/index.ts b/packages/legacy/core/App/localization/fr/index.ts
@@ -610,6 +610,7 @@ const translation = {
         "Parameterizable": "Paramétrable",
         "RefreshQR": "Refresh QR Code (FR)",
         "GenerateNewQR": "Request another proof (FR)",
+        "BackToList": "Back to list (FR)",
         "ShareLink": "Lien de partage",
         "ScanQR": "Show this QR code to the other person (FR)",
         "ScanQRComment": "After the QR code is scanned, a proof request will be sent. (FR)",

diff --git a/packages/legacy/core/App/localization/pt-br/index.ts b/packages/legacy/core/App/localization/pt-br/index.ts
@@ -586,6 +586,7 @@ const translation = {
     "Parameterizable": "Parametrizável",
     "RefreshQR": "Atualizar QR Code",
     "GenerateNewQR": "Requisitar outra prova",
+    "BackToList": "Back to list (PB)",
     "ShareLink": "Compartilhar link",
     "ScanQR": "Mostrar este QR code para a outra pessoa",
     "ScanQRComment": "Depois do QR code ser scaneado, a requisição de prova será enviada.",

diff --git a/packages/legacy/core/App/screens/ProofDetails.tsx b/packages/legacy/core/App/screens/ProofDetails.tsx
@@ -122,7 +122,7 @@ const VerifiedProof: React.FC<VerifiedProofProps> = ({
     }
   }, [navigation])
 
-  const onDone = useCallback(() => {
+  const onBack = useCallback(() => {
     navigation.navigate(Screens.ProofRequests, {})
   }, [navigation])
 
@@ -178,19 +178,19 @@ const VerifiedProof: React.FC<VerifiedProofProps> = ({
         <View style={styles.footerButton}>
           <View style={{ marginBottom: 15 }}>
             <Button
-              title={t('Global.Done')}
-              accessibilityLabel={t('Global.Done')}
-              testID={testIdWithKey('Done')}
+              title={t('Verifier.GenerateNewQR')}
+              accessibilityLabel={t('Verifier.GenerateNewQR')}
+              testID={testIdWithKey('GenerateNewQR')}
               buttonType={ButtonType.Primary}
-              onPress={onDone}
+              onPress={onGenerateNew}
             />
           </View>
           <Button
-            title={t('Verifier.GenerateNewQR')}
-            accessibilityLabel={t('Verifier.GenerateNewQR')}
-            testID={testIdWithKey('GenerateNewQR')}
+            title={t('Verifier.BackToList')}
+            accessibilityLabel={t('Verifier.BackToList')}
+            testID={testIdWithKey('BackToList')}
             buttonType={ButtonType.Secondary}
-            onPress={onGenerateNew}
+            onPress={onBack}
           />
         </View>
       </View>

diff --git a/packages/legacy/core/__tests__/screens/ProofDetails.test.tsx b/packages/legacy/core/__tests__/screens/ProofDetails.test.tsx
@@ -184,7 +184,7 @@ describe('ProofDetails Component', () => {
       const navigation = useNavigation()
       const { findByTestId } = renderView({ recordId: testVerifiedProofRequest.id, isHistory: false })
 
-      const doneButton = await findByTestId(testIdWithKey('Done'))
+      const doneButton = await findByTestId(testIdWithKey('BackToList'))
       fireEvent(doneButton, 'press')
 
       expect(doneButton).not.toBeNull()

diff --git a/packages/legacy/core/__tests__/screens/__snapshots__/ProofDetails.test.tsx.snap b/packages/legacy/core/__tests__/screens/__snapshots__/ProofDetails.test.tsx.snap
@@ -418,7 +418,7 @@ exports[`ProofDetails Component with a verified proof record renders correctly w
             }
           >
             <View
-              accessibilityLabel="Global.Done"
+              accessibilityLabel="Verifier.GenerateNewQR"
               accessibilityRole="button"
               accessibilityState={
                 Object {
@@ -455,7 +455,7 @@ exports[`ProofDetails Component with a verified proof record renders correctly w
                   "padding": 16,
                 }
               }
-              testID="com.ariesbifold:id/Done"
+              testID="com.ariesbifold:id/GenerateNewQR"
             >
               <View
                 style={
@@ -481,13 +481,13 @@ exports[`ProofDetails Component with a verified proof record renders correctly w
                     ]
                   }
                 >
-                  Global.Done
+                  Verifier.GenerateNewQR
                 </Text>
               </View>
             </View>
           </View>
           <View
-            accessibilityLabel="Verifier.GenerateNewQR"
+            accessibilityLabel="Verifier.BackToList"
             accessibilityRole="button"
             accessibilityState={
               Object {
@@ -525,7 +525,7 @@ exports[`ProofDetails Component with a verified proof record renders correctly w
                 "padding": 16,
               }
             }
-            testID="com.ariesbifold:id/GenerateNewQR"
+            testID="com.ariesbifold:id/BackToList"
           >
             <View
               style={
@@ -551,7 +551,7 @@ exports[`ProofDetails Component with a verified proof record renders correctly w
                   ]
                 }
               >
-                Verifier.GenerateNewQR
+                Verifier.BackToList
               </Text>
             </View>
           </View>