Hide VLM files and API #951
Conversation
src/cpp/src/vlm_pipeline.cpp
Outdated
|
|
||
| DecodedResults VLMPipeline::generate( | ||
| const std::string& prompt, | ||
| const std::vector<ov::Tensor>& rgbs, |
There was a problem hiding this comment.
BTW, why do we have overload with multiple images, but don't have with single one?
I think we either need to provide it or keep only overload with explicit prompt, while image(s) are supposed via properties.
There was a problem hiding this comment.
That's the implementation of the second option. Properties are cast to this general signature while the sample encourages to use Proprieties. There's just no reason to hide this general function. Someone pedantic may want to avoid minor cast overhead and use that one directly.
src/cpp/include/openvino/genai/visual_language/vlm_pipeline.hpp
Outdated
Show resolved
Hide resolved
|
It shows merge conflicts with VLM tests & align impl.. Latest wait for those PRs to me merged via queue first. |
|
We could have let it try to merge and see who is faster or not randomly fails. The other one would resolve the conflicts. |
Wovchena
force-pushed
the
hide-VLM-files-and-API
branch
from
21aa927 to
7f0ef7a
Compare
Wovchena
force-pushed
the
hide-VLM-files-and-API
branch
from
7916b42 to
a9d92f0
Compare
3d0fcee
ilya-lavrenov
added
category: visual language
No description provided.