Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace export_MiniCPM-V-2_6.py #957

Closed

Conversation

Wovchena
Copy link
Collaborator

Merge after #951

@ilya-lavrenov ilya-lavrenov added this to the 2024.5 milestone Oct 14, 2024
@ilya-lavrenov ilya-lavrenov self-assigned this Oct 14, 2024
@@ -703,12 +703,13 @@ jobs:
source ./ov/setupvars.sh
python -m pip install ./thirdparty/openvino_tokenizers/[transformers] --pre --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly
python -m pip install --upgrade-strategy eager -r ./samples/requirements.txt --pre --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly
python ./samples/cpp/visual_language_chat/export_MiniCPM-V-2_6.py ./miniCPM-V-2_6/
python -m pip install -U "optimum<1.23" --no-dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be moved to samples/requirements.txt ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a conflicting thing. The only possible thing is to add it to README.md. But I want to see if it fixes by itself before the release

@Wovchena Wovchena marked this pull request as ready for review October 15, 2024 06:31
@Wovchena Wovchena enabled auto-merge October 15, 2024 06:31
@Wovchena Wovchena disabled auto-merge October 15, 2024 06:32
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 16, 2024
@Wovchena Wovchena enabled auto-merge October 16, 2024 07:12
@Wovchena Wovchena added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@Wovchena Wovchena added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@Wovchena Wovchena added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@Wovchena Wovchena added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@github-actions github-actions bot added category: WWB PR changes WWB category: continuous batching Continuous batching category: sampling Sampling / Decoding algorithms category: GHA CI based on Github actions category: samples GenAI samples labels Oct 16, 2024
@Wovchena Wovchena enabled auto-merge October 16, 2024 23:09
@Wovchena Wovchena disabled auto-merge October 17, 2024 06:09
@Wovchena Wovchena marked this pull request as draft October 17, 2024 06:10
ilya-lavrenov pushed a commit that referenced this pull request Oct 17, 2024
A copy of #957 but
installs optimum-intel from branch only for VLM
@ilya-lavrenov
Copy link
Contributor

should be closed?

@Wovchena
Copy link
Collaborator Author

#988 is merged instead

@Wovchena Wovchena closed this Oct 17, 2024
ScottZhang812 pushed a commit to ScottZhang812/_openvino.genai that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: continuous batching Continuous batching category: GHA CI based on Github actions category: samples GenAI samples category: sampling Sampling / Decoding algorithms category: visual language Visual language pipeline category: WWB PR changes WWB Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants