Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libjuju-3.1] Add provision to configure credentials via .zaza.yaml #642

Merged

Conversation

dashmage
Copy link
Contributor

@dashmage dashmage commented Jan 16, 2024

Adds feature similar to #574 to support selecting user provided credential from zaza.yaml.

Similar PR to master branch: #641

Resolves #639

Copy link

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dashmage
Copy link
Contributor Author

@ajkavanagh - could you take a look at this one as well? Thanks!

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00af63d) 89.14% compared to head (25d5b9e) 89.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##           libjuju-3.1     #642   +/-   ##
============================================
  Coverage        89.14%   89.14%           
============================================
  Files               44       44           
  Lines             4689     4691    +2     
============================================
+ Hits              4180     4182    +2     
  Misses             509      509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures are unrelated to this change, although they do need to be addressed at some (near) stage. However, juju 3.1 support is being merged into the main branch shortly and this branch will then be deprecated. So merging this now is low risk.

@ajkavanagh ajkavanagh merged commit 24019fb into openstack-charmers:libjuju-3.1 Jan 19, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants