Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable github workflow #9

Merged
merged 1 commit into from
Jan 25, 2024
Merged

ci: enable github workflow #9

merged 1 commit into from
Jan 25, 2024
+130 −10

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Dec 21, 2023

No description provided.

@jneo8
Copy link
Contributor Author

jneo8 commented Dec 28, 2023

Fail because this charm will bootstrap new controller in the unit, so it required vm machine to used.

@jneo8 jneo8 changed the title ci: enable github workflow [WIP]ci: enable github workflow Dec 28, 2023
@jneo8 jneo8 force-pushed the ci/enable-workflow branch 2 times, most recently from d720d0f to ad3e769 Compare January 16, 2024 03:41
@Pjack Pjack requested review from dashmage and sudeephb January 23, 2024 07:53
dashmage
dashmage suggested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments which might need some input from you.

tests/functional/requirements.txt Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@dashmage
Copy link
Contributor

One additional request would be to explicitly mention somewhere (separate commit for example) that we're deprecating bionic support with this PR. It would be easier to grep for later on if we want to find the exact commit.

@jneo8 jneo8 force-pushed the ci/enable-workflow branch from ad3e769 to 042a645 Compare January 24, 2024 05:59
@jneo8 jneo8 changed the title [WIP]ci: enable github workflow ci: enable github workflow Jan 24, 2024
@jneo8 jneo8 force-pushed the ci/enable-workflow branch from 042a645 to 5eb0faa Compare January 24, 2024 06:15
dashmage
dashmage approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for addressing my comments!

@jneo8
ci: enable github workflow
97ed13c 
- github workflow
- Remove unused dependency
- Drop bionic
@jneo8 jneo8 force-pushed the ci/enable-workflow branch from 5eb0faa to 97ed13c Compare January 25, 2024 06:17
@jneo8 jneo8 merged commit 5ae23bb into master Jan 25, 2024
3 checks passed
@rgildein rgildein deleted the ci/enable-workflow branch April 30, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudeephb sudeephb sudeephb approved these changes

@dashmage dashmage dashmage approved these changes

@Pjack Pjack Pjack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jneo8 @dashmage @Pjack @sudeephb