Add provision to configure credentials via .zaza.yaml #641
Conversation
| model_name, | ||
| config=config, | ||
| cloud_name=cloud_name, | ||
| credential_name=credential_name, |
There was a problem hiding this comment.
Normally, I'd suggest that this was:
credential_name=credential_name or None,to force it to None if it is "not-truthy" to be really explicit about what is passed, but I've checked the python-libjuju and it only does a truthy check on credential_name anyway. Oh well.
There was a problem hiding this comment.
That's a good suggestion! I was mostly following the layout of the other parameters 😄
There was a problem hiding this comment.
That's a good suggestion! I was mostly following the layout of the other parameters 😄
And I think that's really reasonable as well! :-)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #641 +/- ##
=======================================
Coverage 89.43% 89.43%
=======================================
Files 44 44
Lines 4693 4695 +2
=======================================
+ Hits 4197 4199 +2
Misses 496 496 ☔ View full report in Codecov by Sentry. |
Adds feature similar to #574 to support selecting user provided credential from
zaza.yaml.Resolves #639