Fix subprocess handling #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-wat
commented
Mar 7, 2019
| { | ||
| std::vector<std::string> args; |
There was a problem hiding this comment.
Doing string processing after fork causes a kind of dead lock on strict environments like Alpine.
| if (pid_ > 0) | ||
| { | ||
| ROS_INFO("killing ypspur-coordinator (%d)", (int)pid_); | ||
| kill(pid_, SIGINT); |
There was a problem hiding this comment.
without wait, child process goes zombie.
|
@DaikiMaekawa please take a look |
DaikiMaekawa
reviewed
Mar 7, 2019
| { | ||
| const int err = errno; | ||
| ROS_ERROR("failed to fork process: %s", strerror(err)); | ||
| throw(std::string("failed to fork process")); |
There was a problem hiding this comment.
Can you define a dedicated exception for these?
std::string could throw an exception during use.
There was a problem hiding this comment.
Many other part has same problem. I will fix them in separate PR. #51
| args.push_back(param_file_); | ||
| } | ||
|
|
||
| char **argv = new char *[args.size() + 1]; |
src/ypspur_ros.cpp
Outdated
| args.push_back(std::string("--admask")); | ||
| args.push_back(ad_mask); | ||
| args.push_back(std::string("--msq-key")); | ||
| args.push_back(std::to_string(key_)); |
|
@DaikiMaekawa addressed your comments. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #47
fix #49