Trim filtered table to original time range in TabOpLowPassFilter #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkuchida
approved these changes
Nov 16, 2024
| CHECK(out.getNumRows() == 6); | ||
| CHECK(out.getIndependentColumn().front() == 1); | ||
| CHECK(out.getIndependentColumn().back() == 6); | ||
| } |
… fix missing EOL; update changelog
nickbianco
commented
Nov 18, 2024
There was a problem hiding this comment.
Thanks @tkuchida! Requesting a quick re-review since I made some additional changes on top of the requested fix.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @tkuchida)
tkuchida
approved these changes
Nov 19, 2024
OpenSim/Simulation/TableProcessor.h
Outdated
| TabOpLowPassFilter() { constructProperty_cutoff_frequency(-1); } | ||
| OpenSim_DECLARE_PROPERTY(trim_to_original_time_range, bool, | ||
| "Trim the rows of the output table to match the original table's " | ||
| "time range after padding and filtering (default: true)."); |
There was a problem hiding this comment.
Perhaps delete "after padding" as I don't think the user-facing documentation explains padding (what/why).
nickbianco
commented
Nov 19, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @tkuchida)
OpenSim/Simulation/TableProcessor.h
Outdated
| TabOpLowPassFilter() { constructProperty_cutoff_frequency(-1); } | ||
| OpenSim_DECLARE_PROPERTY(trim_to_original_time_range, bool, | ||
| "Trim the rows of the output table to match the original table's " | ||
| "time range after padding and filtering (default: true)."); |
|
Merging this. Thanks @tkuchida! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3287
Brief summary of changes
Updates
TabOpLowPassFilterto trim the table back to the original time range.Testing I've completed
Added a unit test to
testTableProcessor.cpp.Looking for feedback on...
CHANGELOG.md (choose one)
This change is