OCPBUGS-36630: Add hack Makefile target to build CI version of router image

[alebedev87]

This PR enables the build of the CI version router image on local. The same base and router dockerfiles are used by the new target. Use case: I want the same image that the CI would build but with my fix.

[openshift-ci-robot]

@alebedev87: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from alebedev87. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gcs278]

Can we use dockerfile build args https://docs.docker.com/build/guide/build-args/? You can apply default arguments.

[alebedev87]

I didn't want to touch the existing dockerfiles in any way just for a hack command. But let's give it a shot and see if the CI passes.

[alebedev87]

The rebase conflict I'm having on this PR is due to the ART automation which updates images/router/haproxy/Dockerfile.rhel8's FROM. The ARG may be preventing this automation from working smoothly.

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-36630, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR enables the build of the CI version router image on local. The same base and router dockerfiles are used by the new target. Use case: I want the same image that the CI would build but with my fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ShudiLi]

/jira refresh

[openshift-ci-robot]

@ShudiLi: This pull request references Jira Issue OCPBUGS-36630, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rfredette]

/assign

[grzpiotrowski]

Since this touches the hacks, I wanted to throw in a little change to propose alongside. Please ignore if this shouldn't be included here.

In HACKING.md: lines 28-29 describe theDockerfile.debug file and state that:

(...) The outputted image uses `centos:8` as it's base
since installing packages on an OpenShift RHEL base image requires RHEL entitlements.

but ubi9 is actually used as the base image there instead. This mention of centos:8 could be deleted then?

[alebedev87]

/retest

[ShudiLi]

/label qe-approved
thanks

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-36630, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR enables the build of the CI version router image on local. The same base and router dockerfiles are used by the new target. Use case: I want the same image that the CI would build but with my fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[alebedev87]

/jira refresh

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-36630, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ShudiLi]

/label qe-approved
thanks

[alebedev87]

Reverted the default image repository to openshift to reduce the diff with #609.

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.