tmp: add buildarg for the base image of haproxy dockerfile

openshift · Jul 5, 2024 · eb1034e · eb1034e
1 parent 0df56d3
commit eb1034e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/hack/Makefile.debug b/hack/Makefile.debug
@@ -14,9 +14,7 @@ new-openshift-router-image:
 
 new-ci-router-image:
 	$(IMAGEBUILDER) build -t $(IMAGE_BASE):$(TAG) -f images/router/base/Dockerfile.rhel .
-	cp -f images/router/haproxy/Dockerfile.rhel8 images/router/haproxy/Dockerfile.rhel8.debug
-	sed -i "s|FROM .*|FROM $(IMAGE_BASE):$(TAG)|" images/router/haproxy/Dockerfile.rhel8.debug
-	$(IMAGEBUILDER) build -t $(IMAGE):$(TAG) -f images/router/haproxy/Dockerfile.rhel8.debug .
+	$(IMAGEBUILDER) build -t $(IMAGE):$(TAG) -f images/router/haproxy/Dockerfile.rhel8 --build-arg="BASE=$(IMAGE_BASE):$(TAG)" .
 
 push:
 	$(IMAGEBUILDER) tag $(IMAGE):$(TAG) $(REGISTRY)/$(IMAGE):$(TAG)

diff --git a/images/router/haproxy/Dockerfile.rhel8 b/images/router/haproxy/Dockerfile.rhel8
@@ -1,4 +1,5 @@
-FROM registry.ci.openshift.org/ocp/4.16:haproxy-router-base
+ARG BASE=registry.ci.openshift.org/ocp/4.16:haproxy-router-base
+FROM ${BASE}
 RUN INSTALL_PKGS="socat haproxy28 rsyslog procps-ng util-linux" && \
     yum install -y $INSTALL_PKGS && \
     rpm -V $INSTALL_PKGS && \