Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[konflux] Fail when SBOMs can't be accessed #1166

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[konflux] Fail when SBOMs can't be accessed #1166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doozer/doozerlib/backend/konflux_image_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,8 @@ async def _get_for_arch(arch):
return source_rpms

results = await asyncio.gather(*(_get_for_arch(arch) for arch in arches))
if None in results:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to check this, because it feels wrong, but it is exactly right:

>>> a = [1, 'a']
>>> None in a
False
>>> a = [1, 'a', None]
>>> None in a
True
>>> a = [1, 'a', []]
>>> None in a
False
>>> a = [1, 'a', '']
>>> None in a
False

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

for arch, result in zip(arches, results):
    if not result:
        raise ChildProcessError(f"Could not get rpms from SBOM for arch {arch}")

raise ChildProcessError("Could get data from SBOM")
installed_packages = set()
for srpms in results:
installed_packages.update(srpms)
Expand Down
Loading