[konflux] Fail when SBOMs can't be accessed #1166
Conversation
ashwindasr
force-pushed
the
fix-sbom-error
branch
from
bc1010e
to
8fc060b
Compare
ashwindasr
force-pushed
the
fix-sbom-error
branch
from
8fc060b
to
9ccd9ee
Compare
|
@ashwindasr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -281,6 +281,8 @@ async def _get_for_arch(arch): | |||
| return source_rpms | |||
|
|
|||
| results = await asyncio.gather(*(_get_for_arch(arch) for arch in arches)) | |||
| if None in results: | |||
There was a problem hiding this comment.
I had to check this, because it feels wrong, but it is exactly right:
>>> a = [1, 'a']
>>> None in a
False
>>> a = [1, 'a', None]
>>> None in a
True
>>> a = [1, 'a', []]
>>> None in a
False
>>> a = [1, 'a', '']
>>> None in a
False
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 154f648
into
openshift-eng:main
| @@ -281,6 +281,8 @@ async def _get_for_arch(arch): | |||
| return source_rpms | |||
|
|
|||
| results = await asyncio.gather(*(_get_for_arch(arch) for arch in arches)) | |||
| if None in results: | |||
There was a problem hiding this comment.
for arch, result in zip(arches, results):
if not result:
raise ChildProcessError(f"Could not get rpms from SBOM for arch {arch}")
Job run was green, but was silently failing with
job run