Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint #620

Closed
wants to merge 15 commits into from
Closed
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased]
### Added
- Added pylint `missing-function-docstring`, `missing-class-docstring`, `protected-access`, `duplicate-code`, `no-member`,
`missing-module-docstring`, `unused-argument`, `consider-using-f-string`, `super-with-arguments`, `too-few-public-methods`,
`redefined-builtin`, `line-too-long`, `too-many-arguments`, `redefined-outer-name`, `import-outside-toplevel`,
`useless-object-inheritance`, `unused-variable`, `unexpected-keyword-arg`, `raise-missing-from`, `too-many-locals`,
`unnecessary-dunder-call`, `wrong-import-position`, `too-many-public-methods`, `invalid-unary-operand-type`,
`attribute-defined-outside-init`, `unspecified-encoding`, `no-else-return`, `invalid-overridden-method`, `cyclic-import`,
`too-many-branches`, `dangerous-default-value`, `arguments-renamed`, `pointless-statement` ([#620](https://github.com/opensearch-project/opensearch-py/pull/620))
- Added pylint `line-too-long` and `invalid-name` ([#590](https://github.com/opensearch-project/opensearch-py/pull/590))
- Added pylint `pointless-statement` ([#611](https://github.com/opensearch-project/opensearch-py/pull/611))
- Added a log collection guide ([#579](https://github.com/opensearch-project/opensearch-py/pull/579))
Expand Down
10 changes: 9 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,17 @@ target-version = 'py33'
ignore_missing_imports=True

[pylint]

max-line-length = 240
good-names-rgxs = ^[_a-z][_a-z0-9]?$ # allow for 1-character variable names

[pylint.MESSAGE CONTROL]
disable = all
enable = line-too-long, invalid-name, pointless-statement
enable = line-too-long, invalid-name, pointless-statement,
missing-function-docstring, missing-class-docstring, protected-access, duplicate-code, no-member,
missing-module-docstring, unused-argument, consider-using-f-string, super-with-arguments, too-few-public-methods,
redefined-builtin, line-too-long, too-many-arguments, redefined-outer-name, import-outside-toplevel,
useless-object-inheritance, unused-variable, unexpected-keyword-arg, raise-missing-from, too-many-locals,
unnecessary-dunder-call, wrong-import-position, too-many-public-methods, invalid-unary-operand-type,
attribute-defined-outside-init, unspecified-encoding, no-else-return, invalid-overridden-method, cyclic-import,
too-many-branches, dangerous-default-value, arguments-renamed, pointless-statement
Loading