Pylint #620
Closed
Pylint #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled remaining pylint defaults Signed-off-by: Sejal Verma <[email protected]>
sejal-verma
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
|
@sejal-verma, DCO check is failing and also changelog entry is missing. |
Signed-off-by: Sejal Verma <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 72.09% 72.12% +0.02%
==========================================
Files 89 89
Lines 7939 7939
==========================================
+ Hits 5724 5726 +2
+ Misses 2215 2213 -2 ☔ View full report in Codecov by Sentry. |
Enabled remaining pylint defaults Signed-off-by: Sejal Verma <[email protected]> Signed-off-by: Sejal <[email protected]>
dblock
requested changes
Nov 28, 2023
# Conflicts: # setup.cfg
Signed-off-by: Sejal Verma <[email protected]>
Signed-off-by: Sejal Verma <[email protected]>
Signed-off-by: Sejal <[email protected]> Signed-off-by: Sejal Verma <[email protected]>
Signed-off-by: Sejal <[email protected]> Signed-off-by: Sejal Verma <[email protected]>
Enabled remaining pylint defaults Signed-off-by: Sejal <[email protected]>
# Conflicts: # setup.cfg
dblock
requested changes
Nov 29, 2023
Signed-off-by: Sejal <[email protected]>
Signed-off-by: Sejal <[email protected]>
Signed-off-by: Sejal <[email protected]>
…arch-py into pylint_enable
|
Closing this, please reopen addressing #620 (review). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables lints in setup.cfg
Issues Resolved
Enables remaining pylint defaults
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.