Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit and Finish Changes for DataStreams and Rollups #1153

Merged
merged 10 commits into from
Sep 2, 2024
Merged

Fit and Finish Changes for DataStreams and Rollups #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
afb17c0
Fit and Finish Changes for DataStreams and Rollups
Aug 28, 2024
1e2bc51
Makde changes for Rollup page
Aug 28, 2024
e3581ca
Notification page changes
Aug 28, 2024
1bc4022
Address PR comments
Aug 29, 2024
10d330a
Review comments
Aug 29, 2024
72329e4
Address offline review comments
Aug 29, 2024
b7dd72f
This commit includes-
Sep 2, 2024
07a7b54
Old UI title changes
Sep 2, 2024
af23436
make gaps between bottom button small
Sep 2, 2024
2d53ee1
resolve conflicts
Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/components/ContentPanel/ContentPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const ContentPanel: React.SFC<ContentPanelProps> = ({
const isGhost = color === "ghost";
const titleContent = (
<EuiFlexGroup
style={{ ...(noExtraPadding ? { marginTop: 0, marginBottom: 0 } : {}), padding: isGhost || accordion ? undefined : "0px 10px" }}
style={{ ...(noExtraPadding ? { marginTop: 0, marginBottom: 0 } : {}), padding: isGhost || accordion ? undefined : "0px 16px" }}
justifyContent="spaceBetween"
alignItems="flexStart"
>
Expand Down Expand Up @@ -111,7 +111,7 @@ const ContentPanel: React.SFC<ContentPanelProps> = ({
{children ? (
<div
style={{
padding: isGhost ? undefined : "0px 10px",
padding: isGhost ? undefined : "0px 16px",
...bodyStyles,
display: accordion && isAccordionOpen === "closed" ? "none" : undefined,
}}
Expand Down
4 changes: 2 additions & 2 deletions public/components/ContentPanel/__snapshots__/ContentPanel.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`<ContentPanel /> spec renders the component 1`] = `
>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsFlexStart euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
style="padding: 0px 10px;"
style="padding: 0px 16px;"
>
<div
class="euiFlexItem"
Expand Down Expand Up @@ -53,7 +53,7 @@ exports[`<ContentPanel /> spec renders the component 1`] = `
class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginXSmall"
/>
<div
style="padding: 0px 10px;"
style="padding: 0px 16px;"
>
<div>
Testing ContentPanel
Expand Down
1 change: 1 addition & 0 deletions public/components/DescriptionListHoz/DescriptionListHoz.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const DisplayItem = (
const { listItem, ...others } = props;
return (
<EuiDescriptionList
compressed={true}
listItems={[
{
...listItem,
Expand Down
2 changes: 1 addition & 1 deletion public/components/DescriptionListHoz/__snapshots__/DescriptionListHoz.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ exports[`<DescriptionListHoz /> spec renders the component 1`] = `
class="euiFlexItem"
>
<dl
class="euiDescriptionList euiDescriptionList--row"
class="euiDescriptionList euiDescriptionList--row euiDescriptionList--compressed"
>
<dt
class="euiDescriptionList__title"
Expand Down
14 changes: 8 additions & 6 deletions public/containers/ClearCacheModal/ClearCacheModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,14 @@ export default function ClearCacheModal(props: ClearCacheModalProps) {
)}
</div>
<EuiCallOut color="warning" iconType="warning" hidden={blockedItems.length == 0} size="s">
<p>{blockHint}</p>
<EuiText size="s">
<p>{blockHint}</p>
</EuiText>
<ul style={{ listStyleType: "disc", listStylePosition: "inside" }}>
{blockedItems.map((item) => (
<li key={item}>{item}</li>
<EuiText size="s">
<li key={item}>{item}</li>
</EuiText>
))}
</ul>
</EuiCallOut>
Expand All @@ -217,11 +221,9 @@ export default function ClearCacheModal(props: ClearCacheModalProps) {
<EuiModal onClose={onClose}>
<EuiModalHeader>
<EuiModalHeaderTitle>
{" "}
<EuiText size="s">
{" "}
<h2>Clear cache for {type}</h2>{" "}
</EuiText>{" "}
<h2>Clear cache for {type}</h2>
</EuiText>
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down
4 changes: 0 additions & 4 deletions public/containers/ClearCacheModal/__snapshots__/ClearCacheModal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,14 @@ HTMLCollection [
<div
class="euiModalHeader__title"
>

<div
class="euiText euiText--small"
>

<h2>
Clear cache for
indexes
</h2>

</div>

</div>
</div>
<div
Expand Down
2 changes: 1 addition & 1 deletion public/containers/ErrorNotification/__snapshots__/ErrorNotification.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`<ErrorNotification /> spec renders the component 1`] = `
>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsFlexStart euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
style="padding: 0px 10px;"
style="padding: 0px 16px;"
>
<div
class="euiFlexItem"
Expand Down
20 changes: 13 additions & 7 deletions public/containers/FlushIndexModal/FlushIndexModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,20 @@ export default function FlushIndexModal(props: FlushIndexModalProps) {
<EuiModal onClose={onClose}>
<EuiModalHeader>
<EuiModalHeaderTitle data-test-subj="flushModalTitle">
{" "}
<EuiText size="s">
{" "}
<h2>Flush {flushTarget}</h2>{" "}
</EuiText>{" "}
<h2>Flush {flushTarget}</h2>
</EuiText>
</EuiModalHeaderTitle>
</EuiModalHeader>

<EuiModalBody>
<div style={{ lineHeight: 1.5 }}>
{/* we will not display this part if not flushAll and there is no flushable items */}
{flushAll && <p>{flushAllMessage}</p>}
{flushAll && (
<EuiText size="s">
<p>{flushAllMessage}</p>
</EuiText>
)}
{!!unBlockedItems.length && (
<>
<EuiText size="s">
Expand All @@ -187,10 +189,14 @@ export default function FlushIndexModal(props: FlushIndexModalProps) {
)}
<EuiSpacer />
<EuiCallOut data-test-subj="flushBlockedCallout" color="warning" size="s" hidden={!blockedItems.length}>
<p>{blockedItemsMessageTemplate(flushTarget)}</p>
<EuiText size="s">
<p>{blockedItemsMessageTemplate(flushTarget)}</p>
</EuiText>
<ul style={{ listStyleType: "disc", listStylePosition: "inside" }}>
{blockedItems.map((item) => (
<li key={item}>{item}</li>
<EuiText size="s">
<li key={item}>{item}</li>
</EuiText>
))}
</ul>
</EuiCallOut>
Expand Down
Loading
Loading