Fit and Finish Changes for DataStreams and Rollups #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skumawat2025
force-pushed
the
fit-and-finish
branch
2 times, most recently
from
2ee5c11 to
fba0e6e
Compare
skumawat2025
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
|
@skumawat2025 can you please add details to the PR description. |
|
Not sure if in scope, but the context menu here ( |
public/pages/CreateDataStream/containers/DataStreamDetail/DataStreamDetail.tsx
Show resolved
Hide resolved
|
The text here should also be wrapped in |
|
The modal header here should be
|
|
The modal text here should be
|
skumawat2025
force-pushed
the
fit-and-finish
branch
from
14c821b to
8713281
Compare
|
@danieldong51 Thanks a lot for reviewing this PR. @skumawat2025 let's work with Dan to get his approval on this PR. |
|
LGTM, reviewed the pages offline. |
SuZhou-Joe
previously approved these changes
Aug 29, 2024
|
I found a few more small changes, but everything else looked good! Context menu in
The titles when using the old UI for the following pages should be
|
skumawat2025
force-pushed
the
fit-and-finish
branch
from
5388568 to
b366886
Compare
Thanks for looking into this PR. Have made these above changes in the latest commit. |
skumawat2025
force-pushed
the
fit-and-finish
branch
from
ef62328 to
2b45ec3
Compare
added 5 commits
September 2, 2024 14:07
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
added 5 commits
September 2, 2024 14:07
Signed-off-by: Sandeep Kumawat <[email protected]>
1. Remove padding from view Json Modal of rollup details page 2. Make steps smaller for create rollup page. 3. Remove extra padding from bottom buttons of rollup page Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
force-pushed
the
fit-and-finish
branch
from
2b45ec3 to
2d53ee1
Compare
SuZhou-Joe
approved these changes
Sep 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
* Fit and Finish Changes for DataStreams and Rollups Signed-off-by: Sandeep Kumawat <[email protected]> * Makde changes for Rollup page Signed-off-by: Sandeep Kumawat <[email protected]> * Notification page changes Signed-off-by: Sandeep Kumawat <[email protected]> * Address PR comments Signed-off-by: Sandeep Kumawat <[email protected]> * Review comments Signed-off-by: Sandeep Kumawat <[email protected]> * Address offline review comments Signed-off-by: Sandeep Kumawat <[email protected]> * This commit includes- 1. Remove padding from view Json Modal of rollup details page 2. Make steps smaller for create rollup page. 3. Remove extra padding from bottom buttons of rollup page Signed-off-by: Sandeep Kumawat <[email protected]> * Old UI title changes Signed-off-by: Sandeep Kumawat <[email protected]> * make gaps between bottom button small Signed-off-by: Sandeep Kumawat <[email protected]> * resolve conflicts Signed-off-by: Sandeep Kumawat <[email protected]> --------- Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> (cherry picked from commit a7efceb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Sep 3, 2024
* Fit and Finish Changes for DataStreams and Rollups * Makde changes for Rollup page * Notification page changes * Address PR comments * Review comments * Address offline review comments * This commit includes- 1. Remove padding from view Json Modal of rollup details page 2. Make steps smaller for create rollup page. 3. Remove extra padding from bottom buttons of rollup page * Old UI title changes * make gaps between bottom button small * resolve conflicts --------- (cherry picked from commit a7efceb) Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making fit and finish changes for DataStreams, Rollups and Notification settings pages according to the guidance
The change mostly include.
Video:
Screenshare.-.2024-08-29.3_03_27.PM.mp4
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.