fix(t2viz): string escape should only escape field
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
lezzago,
joshuali925,
anirudha,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
Hailong-am
reviewed
Sep 25, 2024
| @@ -108,7 +108,8 @@ export class Text2Vega { | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| const escapeField = (json: any, field: string) => { | |||
| if (json[field]) { | |||
| if (typeof json[field] === 'string') { | |||
| // Only escape field which name is 'field' | |||
| if (typeof json[field] === 'string' && field === 'field') { | |||
There was a problem hiding this comment.
can we have a unit test to cover this?
There was a problem hiding this comment.
Yes, unit tests for t2viz will come in a separate PR
Hailong-am
approved these changes
Sep 25, 2024
Signed-off-by: Yulong Ruan <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 64fb466) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 64fb466) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fieldfieldwhen vega have different layersIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.