Skip to content

Commit

Permalink
fix(t2viz): string escape should only escape field (#325) (#326)
Browse files Browse the repository at this point in the history
Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit 64fb466)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent 5e62ce0 commit d45d519
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion public/components/visualization/text2vega.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ export class Text2Vega {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const escapeField = (json: any, field: string) => {
if (json[field]) {
if (typeof json[field] === 'string') {
// Only escape field which name is 'field'
if (typeof json[field] === 'string' && field === 'field') {
json[field] = json[field].replace(/\./g, '\\.');
}
if (typeof json[field] === 'object') {
Expand All @@ -132,6 +133,7 @@ export class Text2Vega {

// need to escape field: geo.city -> field: geo\\.city
escapeField(res, 'encoding');
escapeField(res, 'layer');
return res;
}

Expand Down

0 comments on commit d45d519

Please sign in to comment.