[Backport 2.x] [Auto Suggest] PPL & SQL Value Suggestion

changelogs/fragments/8275.yml

@@ -0,0 +1,2 @@
+feat:
+- Autocomplete Value Suggestion ([#8275](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8275))

src/plugins/data/common/constants.ts

@@ -105,6 +105,8 @@ export const UI_SETTINGS = {
   FILTERS_PINNED_BY_DEFAULT: 'filters:pinnedByDefault',
   FILTERS_EDITOR_SUGGEST_VALUES: 'filterEditor:suggestValues',
   QUERY_ENHANCEMENTS_ENABLED: 'query:enhancements:enabled',
+  QUERY_ENHANCEMENTS_SUGGEST_VALUES: 'query:enhancements:suggestValues',
+  QUERY_ENHANCEMENTS_SUGGEST_VALUES_LIMIT: 'query:enhancements:suggestValuesLimit',
   QUERY_DATAFRAME_HYDRATION_STRATEGY: 'query:dataframe:hydrationStrategy',
   SEARCH_QUERY_LANGUAGE_BLOCKLIST: 'search:queryLanguageBlocklist',
   NEW_HOME_PAGE: 'home:useNewHomePage',

src/plugins/data/public/antlr/dql/code_completion.test.ts

@@ -6,176 +6,12 @@
 import { monaco } from '@osd/monaco';
 import { getSuggestions } from './code_completion';
 import { DataPublicPluginStart, IDataPluginServices } from '../../types';
-import { IndexPattern } from '../../index_patterns';
+import { testingIndex } from '../shared/constants';
 
 /**
  * Constants
  */
 
-const testingIndex = ({
-  title: 'opensearch_dashboards_sample_data_flights',
-  fields: [
-    {
-      count: 0,
-      name: 'Carrier',
-      displayName: 'Carrier',
-      type: 'string',
-      esTypes: ['keyword'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: true,
-      subType: undefined,
-    },
-    {
-      count: 2,
-      name: 'DestCityName',
-      displayName: 'DestCityName',
-      type: 'string',
-      esTypes: ['keyword'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: true,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: 'DestCountry',
-      displayName: 'DestCountry',
-      type: 'string',
-      esTypes: ['keyword'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: true,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: 'DestWeather',
-      displayName: 'DestWeather',
-      type: 'string',
-      esTypes: ['keyword'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: true,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: 'DistanceMiles',
-      displayName: 'DistanceMiles',
-      type: 'number',
-      esTypes: ['float'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: true,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: 'FlightDelay',
-      displayName: 'FlightDelay',
-      type: 'boolean',
-      esTypes: ['boolean'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: true,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: 'FlightNum',
-      displayName: 'FlightNum',
-      type: 'string',
-      esTypes: ['keyword'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: true,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: 'OriginWeather',
-      displayName: 'OriginWeather',
-      type: 'string',
-      esTypes: ['keyword'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: true,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: '_id',
-      displayName: '_id',
-      type: 'string',
-      esTypes: ['_id'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: false,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: '_index',
-      displayName: '_index',
-      type: 'string',
-      esTypes: ['_index'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: false,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: '_score',
-      displayName: '_score',
-      type: 'number',
-      scripted: false,
-      searchable: false,
-      aggregatable: false,
-      readFromDocValues: false,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: '_source',
-      displayName: '_source',
-      type: '_source',
-      esTypes: ['_source'],
-      scripted: false,
-      searchable: false,
-      aggregatable: false,
-      readFromDocValues: false,
-      subType: undefined,
-    },
-    {
-      count: 0,
-      name: '_type',
-      displayName: '_type',
-      type: 'string',
-      esTypes: ['_type'],
-      scripted: false,
-      searchable: true,
-      aggregatable: true,
-      readFromDocValues: false,
-      subType: undefined,
-    },
-  ],
-  getFieldByName: jest.fn((fieldName: string) => {
-    return testingIndex.fields.find((field) => field.name === fieldName);
-  }),
-} as unknown) as IndexPattern;
-
 const booleanOperatorSuggestions = [
   { text: 'or', type: 11, detail: 'Operator', insertText: 'or ' },
   { text: 'and', type: 11, detail: 'Operator', insertText: 'and ' },
@@ -225,8 +61,6 @@ const allCarrierValueSuggestions = [
   { text: 'OpenSearch-Air', type: 13, detail: 'Value', insertText: '"OpenSearch-Air" ' },
 ];
 
-const carrierWithNotSuggestions = allCarrierValueSuggestions.concat(notOperatorSuggestion);
-
 const logCarrierValueSuggestion = [
   { text: 'Logstash Airways', type: 13, detail: 'Value', insertText: '"Logstash Airways" ' },
 ];

src/plugins/data/public/antlr/dql/code_completion.ts

@@ -18,7 +18,7 @@ import { IndexPattern, IndexPatternField } from '../../index_patterns';
 import { QuerySuggestion, QuerySuggestionGetFnArgs } from '../../autocomplete';
 import { DQLParserVisitor } from './.generated/DQLParserVisitor';
 import { IDataPluginServices } from '../..';
-import { fetchFieldSuggestions } from '../shared/utils';
+import { formatFieldsToSuggestions } from '../shared/utils';
 import { SuggestionItemDetailsTags } from '../shared/constants';
 
 const findCursorIndex = (
@@ -128,7 +128,7 @@ export const getSuggestions = async ({
     // check to see if field rule is a candidate. if so, suggest field names
     if (candidates.rules.has(DQLParser.RULE_field)) {
       completions.push(
-        ...fetchFieldSuggestions(indexPattern, (field: string) => {
+        ...formatFieldsToSuggestions(indexPattern, (field: string) => {
           const indexField = indexPattern.getFieldByName(field);
           if (indexField && ['boolean', 'string'].includes(indexField.type)) {
             return `${field} : `;